This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
sidenav: should be display: flex by default
#10040
Labels
has: Pull Request
A PR has been created to address this issue
P3: important
Important issues that really should be fixed when possible.
type: bug
Milestone
Comments
Splaktar
changed the title
display: flex by default.display: flex by default
Splaktar
added
the
needs: demo
|
Here's a simple demo of this. It's true that we have the following behaviors:
We should use |
Splaktar
added
for: external contributor
P3: important
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Actual Behavior:
What is the issue? *md-sidenav scss sets some flexbox properties (like here: https://github.com/angular/material/blob/master/src/components/sidenav/sidenav.scss#L8 ), but then only in locked states it actually gets
display: flexapplied (e.g. here: https://github.com/angular/material/blob/master/src/components/sidenav/sidenav.scss#L58 ).This means that a sidenav which is open, but not locked open can have a different layout then when it is locked open. But one usually wants the contents of the sidenav to be the same whether or not is locked open.
What is the expected behavior?The layout of the sidenav should always be the same. Whether it's just open or locked open.
Proposed solutionAdd
display: flex;by defaultAngular Versions: *
Angular Version:1.5.8Angular Material Version:1.1.1The text was updated successfully, but these errors were encountered: