fix(material/slider): avoid manual fixing values on pointer up #26215

wagnermaciel · 2022-12-08T15:50:06Z

Fixes issue bug(mat-slider): drag, blur values on FireFox in Material v15 #26172

src/material/slider/slider-input.ts

src/material/slider/slider.spec.ts

mmalerba

LGTM

* fix(material/slider): avoid manual fixing values on pointer up * Fixes issue #26172 * fixup! fix(material/slider): avoid manual fixing values on pointer up * fixup! fix(material/slider): avoid manual fixing values on pointer up * fixup! fix(material/slider): avoid manual fixing values on pointer up (cherry picked from commit 3998906)

The `dragStart` and `dragEnd` events were being emitted in the `_fixValue` method, however the call to `_fixValue` was removed from the ending sequence in angular#26215. This meant that the `dragEnd` event was no longer being emitted. These changes move the `dragStart` and `dragEnd` events into the pointer down/up handlers instead since emitting them has nothing to do with fixing the value. Fixes angular#26285.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.0.1` -> `15.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.0.1/15.0.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.0.1` -> `15.0.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.0.1/15.0.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.0.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1503-velvet-village-2022-12-14) [Compare Source](angular/components@15.0.2...15.0.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [325475774f](angular/components@3254757) | fix | **stepper:** set focus origin when navigating with keyboard ([#26239](angular/components#26239)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [80c4321ddd](angular/components@80c4321) | fix | **core:** better handling of css variables in theme palettes ([#26260](angular/components#26260)) | | [67db1a6043](angular/components@67db1a6) | fix | **form-field:** allow getting harness by validity ([#26232](angular/components#26232)) | | [df7ac2709a](angular/components@df7ac27) | fix | **form-field:** prevent focus overlay stealing clicks ([#26229](angular/components#26229)) | | [1e93df3ab3](angular/components@1e93df3) | fix | **menu:** add selector for projecting non-Material icons ([#26235](angular/components#26235)) | | [83825bd5c3](angular/components@83825bd) | fix | **schematics:** fix card tmpl migration ([#26169](angular/components#26169)) | | [ae3c77835a](angular/components@ae3c778) | fix | **schematics:** fix transform for FloatLabelType ([#26234](angular/components#26234)) | | [fee5d0b7d3](angular/components@fee5d0b) | fix | **slider:** avoid manual fixing values on pointer up ([#26215](angular/components#26215)) | | [15c77e0950](angular/components@15c77e0) | fix | **tabs:** allow both foreground and background colors to be set ([#26212](angular/components#26212)) | | [0ca8c77349](angular/components@0ca8c77) | fix | **toolbar:** don't override colors of themed buttons ([#26222](angular/components#26222)) | #### Special Thanks Kristiyan Kostadinov, Miles Malerba, Ruslan Nevecheria and Wagner Maciel  ### [`v15.0.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1502-polystyrene-penguin-2022-12-08) [Compare Source](angular/components@15.0.1...15.0.2) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [dac9e81f78](angular/components@dac9e81) | fix | **listbox:** set initial focus to selected option ([#26174](angular/components#26174)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [c388758606](angular/components@c388758) | fix | **button:** ensure svg icon is centered ([#26146](angular/components#26146)) | | [afd6e1a277](angular/components@afd6e1a) | fix | **chips:** set correct cursor on interactive chips ([#26171](angular/components#26171)) | | [639fa52ff1](angular/components@639fa52) | fix | **dialog:** change width to not cut off form field in component example ([#26157](angular/components#26157)) | | [976562f35e](angular/components@976562f) | fix | **form-field:** allow ng-container to be used as prefix/suffix ([#26127](angular/components#26127)) | | [0a617d6f0f](angular/components@0a617d6) | fix | **list:** remove previously removed API ([#26165](angular/components#26165)) | | [679df1a074](angular/components@679df1a) | fix | **schematics:** some snack bar styles not being migrated ([#26180](angular/components#26180)) | | [1ab52961b0](angular/components@1ab5296) | fix | **schematics:** update flat button styles class name mapping ([#26158](angular/components#26158)) | | [3bb07ae9d9](angular/components@3bb07ae) | fix | **tabs:** icons not centered inside tab ([#26053](angular/components#26053)) | | [356aab723c](angular/components@356aab7) | perf | **core:** delegate trigger events ([#26147](angular/components#26147)) | | [a526ede4af](angular/components@a526ede) | perf | **tabs:** reduce amount of CSS generated for background color ([#26186](angular/components#26186)) | #### Special Thanks Amy Sorto, Kristiyan Kostadinov, Miles Malerba, Shauni and Wagner Maciel  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1686 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

The `dragStart` and `dragEnd` events were being emitted in the `_fixValue` method, however the call to `_fixValue` was removed from the ending sequence in #26215. This meant that the `dragEnd` event was no longer being emitted. These changes move the `dragStart` and `dragEnd` events into the pointer down/up handlers instead since emitting them has nothing to do with fixing the value. Fixes #26285.

The `dragStart` and `dragEnd` events were being emitted in the `_fixValue` method, however the call to `_fixValue` was removed from the ending sequence in #26215. This meant that the `dragEnd` event was no longer being emitted. These changes move the `dragStart` and `dragEnd` events into the pointer down/up handlers instead since emitting them has nothing to do with fixing the value. Fixes #26285. (cherry picked from commit 3939bb1)

angular-automatic-lock-bot · 2023-01-13T00:04:15Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

wagnermaciel added 2 commits December 8, 2022 10:49

fix(material/slider): avoid manual fixing values on pointer up

6a35768

* Fixes issue angular#26172

fixup! fix(material/slider): avoid manual fixing values on pointer up

8254111

wagnermaciel marked this pull request as ready for review December 8, 2022 16:46

wagnermaciel requested review from mmalerba and devversion as code owners December 8, 2022 16:46

mmalerba reviewed Dec 8, 2022

View reviewed changes

src/material/slider/slider-input.ts Outdated Show resolved Hide resolved

fixup! fix(material/slider): avoid manual fixing values on pointer up

ee16863

mmalerba requested changes Dec 12, 2022

View reviewed changes

src/material/slider/slider.spec.ts Outdated Show resolved Hide resolved

src/material/slider/slider.spec.ts Outdated Show resolved Hide resolved

fixup! fix(material/slider): avoid manual fixing values on pointer up

9113309

wagnermaciel added the target: patch This PR is targeted for the next patch release label Dec 12, 2022

mmalerba approved these changes Dec 12, 2022

View reviewed changes

wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Dec 13, 2022

wagnermaciel merged commit 3998906 into angular:main Dec 13, 2022

crisbeto mentioned this pull request Dec 18, 2022

fix(material/slider): dragEnd not being emitted #26289

Merged

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(material/slider): avoid manual fixing values on pointer up #26215

fix(material/slider): avoid manual fixing values on pointer up #26215

wagnermaciel commented Dec 8, 2022

mmalerba left a comment

angular-automatic-lock-bot bot commented Jan 13, 2023

fix(material/slider): avoid manual fixing values on pointer up #26215

fix(material/slider): avoid manual fixing values on pointer up #26215

Conversation

wagnermaciel commented Dec 8, 2022

mmalerba left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Jan 13, 2023