Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cdk/scrolling): switch directives to standalone #26236

Merged
merged 1 commit into from Dec 14, 2022
Merged

refactor(cdk/scrolling): switch directives to standalone #26236

merged 1 commit into from Dec 14, 2022
+21 −14

Conversation

crisbeto
Copy link
Member

Switches all of the scrolling directives to standalone so they can be used as host directives.

Fixes #26219.

@crisbeto
refactor(cdk/scrolling): switch directives to standalone
780d8ca 
Switches all of the scrolling directives to standalone so they can be used as host directives.

Fixes angular#26219.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 11, 2022
mmalerba
mmalerba approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 13, 2022
@crisbeto crisbeto merged commit 49749fd into angular:main Dec 14, 2022
crisbeto added a commit that referenced this pull request Dec 14, 2022
@crisbeto
refactor(cdk/scrolling): switch directives to standalone (#26236)
97c95e6 
Switches all of the scrolling directives to standalone so they can be used as host directives.

Fixes #26219.

(cherry picked from commit 49749fd)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CdkScrollable): standalone
2 participants
@crisbeto @mmalerba