refactor(cdk/listbox): convert all directives to standalone #26211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevech
requested review from
devversion,
josephperrott and
jelbourn
as code owners
jelbourn
requested review from
crisbeto and
mmalerba
and removed request for
josephperrott and
jelbourn
|
Not sure why it failed, @crisbeto could you please help figure out what's wrong here? |
|
I'm not sure either. Can you try to rebase? |
Converts all of the `@angular/cdk/listbox` directives to `standalone`. It provides the ability to use these directives as host directives.
nevech
force-pushed
the
cdk-listbox-standalone
branch
from
816f18a
to
7722205
Compare
|
@crisbeto done. Now it seems need to add some labels, but I don't have permission for that. |
crisbeto
pushed a commit
that referenced
this pull request
Dec 14, 2022
Converts all of the `@angular/cdk/listbox` directives to `standalone`. It provides the ability to use these directives as host directives. (cherry picked from commit 8626a26)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all of the
@angular/cdk/listboxdirectives tostandalone. It provides the ability to use these directives as host directives.