fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip #24652

volvachev · 2022-03-23T20:59:22Z

This PR fixes the problem when mat-tooltip-hide triggers the animation of tooltip that has not been shown yet.

Caretaker note: Integration test is failing because selenium wants to click on a select item but instead is clicking on the tooltip

google-cla · 2022-03-23T20:59:26Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

crisbeto

A couple of notes:

I think that the correct approach would be to clear the tooltip opening timeout if the pointer is moved away.
I noticed this when I was reworking the tooltip in a5ab8e9, but I ended up keeping the old behavior, because it caused a lot of screenshot failures internally.

volvachev · 2022-03-24T08:20:09Z

A couple of notes:

I think that the correct approach would be to clear the tooltip opening timeout if the pointer is moved away.

I noticed this when I was reworking the tooltip in a5ab8e9, but I ended up keeping the old behavior, because it caused a lot of screenshot failures internally.

The problem is that during the hide action mat-tooltip-hide class is added which has @keyframes -> opacity: 1; animation. As a result hint is shown and disappears in the end of animation, but it hasn't be shown at all. In case when tooltip shouldn't be shown we need to avoid such animation.

After mouseleave event open timeout wipes.

crisbeto

LGTM

rajibhasan11 · 2022-04-09T07:15:49Z

Any update on this?

zarend · 2022-04-15T16:40:30Z

Hello @volvachev, we're running this PR through Google's internal presubmit. Could you please rebase this branch with master?

volvachev · 2022-04-15T16:55:44Z

Hello @volvachev, we're running this PR through Google's internal presubmit. Could you please rebase this branch with master?

Hi, I did it.

… not visible tooltip Fixes a bug in Angular Material `tooltip` when `mat-tooltip-hide` class trigger animation for not visible tooltip. Fixes angular#24614

zarend · 2022-04-15T18:14:55Z

tyty, the most recent presubmit process from earlier this week had less than ten failures. I'm kicking off a fresh one.

volvachev · 2022-04-15T18:27:01Z

tyty, the most recent presubmit process from earlier this week had less than ten failures. I'm kicking off a fresh one.

So, will my fix be included in new one?

Juszczak · 2022-05-13T11:04:19Z

Any updates?

wagnermaciel · 2022-05-18T14:10:23Z

@volvachev The presubmit process Zach was describing was for this PR. Each PR is processed independently

From the latest presubmit run, I can see that it only had a handful of failures so it (hopefully) shouldn't be too difficult to get through. Unfortunately I haven't been able to prioritize this enough to sit down and debug each failure

NoMercy235 · 2022-06-21T14:01:27Z

Hello! It looks like there are no failed checks anymore. Is there any update on this PR?

cosme-benito · 2022-06-29T11:08:20Z

Any news about this PR? The impacts of this bug are quite unpleasant for the users.

vasyop · 2022-07-11T12:36:44Z

are we there yet?

NoMercy235 · 2022-08-03T13:43:05Z

Pretty please? 🙏

wagnermaciel · 2022-08-03T17:53:43Z

I'll take another look. We got this down pretty close but the internal failures are tough to debug. After rerunning internal tests tonight I'll post an update on how things are looking

wagnermaciel

lgtm

… not visible tooltip (#24652) Fixes a bug in Angular Material `tooltip` when `mat-tooltip-hide` class trigger animation for not visible tooltip. Fixes #24614 (cherry picked from commit 3041cda)

…tion for not visible tooltip (angular#24652)" This reverts commit 3041cda.

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda. (cherry picked from commit c95ecbe)

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda.

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda. (cherry picked from commit c95ecbe)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.1/14.1.2) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.1.1` -> `14.1.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.1/14.1.2) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.1.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1412-cedar-cicada-2022-08-11) [Compare Source](angular/components@14.1.1...14.1.2) ##### material | Commit | Type | Description | | -- | -- | -- | | [69b29046d5](angular/components@69b2904) | fix | **chips:** `selectable="false"` doesn't work on initial assignment ([#24906](angular/components#24906)) | | [0f2ec70c86](angular/components@0f2ec70) | fix | **tooltip:** avoid problem when triggers hide animation for not visible tooltip ([#24652](angular/components#24652)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [0a4d8e9fc4](angular/components@0a4d8e9) | fix | **mdc-list:** set a role on MatNavList and MatActionList ([#25412](angular/components#25412)) | #### Special Thanks Egor Volvachev, Miles Malerba, Wagner Maciel and Zach Arend  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1503 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-09-04T00:05:16Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

volvachev requested a review from andrewseguin as a code owner March 23, 2022 20:59

volvachev force-pushed the fix-tooltip-with-delay branch from 194f3dd to 5746c5d Compare March 23, 2022 21:07

crisbeto reviewed Mar 24, 2022

View reviewed changes

volvachev requested a review from crisbeto March 24, 2022 10:38

crisbeto previously approved these changes Apr 1, 2022

View reviewed changes

crisbeto added P3 action: merge target: patch labels Apr 1, 2022

andrewseguin removed the P3 label Apr 2, 2022

zarend added the needs rebase label Apr 15, 2022

volvachev force-pushed the fix-tooltip-with-delay branch from 5746c5d to 9c7ccef Compare April 15, 2022 16:53

fix(material/tooltip): avoid problem when triggers hide animation for…

f62210d

… not visible tooltip Fixes a bug in Angular Material `tooltip` when `mat-tooltip-hide` class trigger animation for not visible tooltip. Fixes angular#24614

volvachev force-pushed the fix-tooltip-with-delay branch from 9c7ccef to f62210d Compare April 15, 2022 16:57

zarend removed the needs rebase label Apr 15, 2022

andrewseguin assigned wagnermaciel Apr 21, 2022

andrewseguin added the merge: caretaker note label Apr 22, 2022

andrewseguin dismissed crisbeto’s stale review via f62210d May 2, 2022 20:32

mmalerba assigned mmalerba and unassigned wagnermaciel Jun 29, 2022

wagnermaciel approved these changes Aug 4, 2022

View reviewed changes

wagnermaciel merged commit 3041cda into angular:main Aug 4, 2022

wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Aug 9, 2022

Revert "fix(material/tooltip): avoid problem when triggers hide anima…

836f6de

…tion for not visible tooltip (angular#24652)" This reverts commit 3041cda.

wagnermaciel mentioned this pull request Aug 9, 2022

Revert "fix(material/tooltip): avoid problem when triggers hide anima… #25426

Merged

wagnermaciel added a commit that referenced this pull request Aug 9, 2022

Revert "fix(material/tooltip): avoid problem when triggers hide anima…

ab73a24

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda. (cherry picked from commit c95ecbe)

wagnermaciel added a commit that referenced this pull request Aug 9, 2022

Revert "fix(material/tooltip): avoid problem when triggers hide anima…

c95ecbe

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda.

wagnermaciel added a commit that referenced this pull request Aug 9, 2022

Revert "fix(material/tooltip): avoid problem when triggers hide anima…

63f6eb0

…tion for not visible tooltip (#24652)" (#25426) This reverts commit 3041cda. (cherry picked from commit c95ecbe)

sync-by-unito bot mentioned this pull request Aug 16, 2022

build: bump @angular/cdk from 12.2.4 to 14.1.2 numbersprotocol/capture-lite#1949

Closed

This was referenced Aug 23, 2022

build: bump @angular/cdk from 12.2.4 to 14.1.3 numbersprotocol/capture-lite#1961

Closed

build(deps): bump @angular/cdk from 12.2.4 to 14.2.0 numbersprotocol/capture-lite#1992

Closed

sync-by-unito bot mentioned this pull request Sep 1, 2022

build(deps): bump @angular/material from 12.2.4 to 14.2.0 numbersprotocol/capture-lite#2011

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip #24652

fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip #24652

volvachev commented Mar 23, 2022 •

edited by andrewseguin

Loading

google-cla bot commented Mar 23, 2022

crisbeto left a comment

volvachev commented Mar 24, 2022

crisbeto left a comment

rajibhasan11 commented Apr 9, 2022

zarend commented Apr 15, 2022

volvachev commented Apr 15, 2022

zarend commented Apr 15, 2022

volvachev commented Apr 15, 2022

Juszczak commented May 13, 2022

wagnermaciel commented May 18, 2022

NoMercy235 commented Jun 21, 2022

cosme-benito commented Jun 29, 2022

vasyop commented Jul 11, 2022

NoMercy235 commented Aug 3, 2022

wagnermaciel commented Aug 3, 2022

wagnermaciel left a comment

angular-automatic-lock-bot bot commented Sep 4, 2022

fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip #24652

fix(material/tooltip): avoid problem when triggers hide animation for not visible tooltip #24652

Conversation

volvachev commented Mar 23, 2022 • edited by andrewseguin Loading

google-cla bot commented Mar 23, 2022

crisbeto left a comment

Choose a reason for hiding this comment

volvachev commented Mar 24, 2022

crisbeto left a comment

Choose a reason for hiding this comment

rajibhasan11 commented Apr 9, 2022

zarend commented Apr 15, 2022

volvachev commented Apr 15, 2022

zarend commented Apr 15, 2022

volvachev commented Apr 15, 2022

Juszczak commented May 13, 2022

wagnermaciel commented May 18, 2022

NoMercy235 commented Jun 21, 2022

cosme-benito commented Jun 29, 2022

vasyop commented Jul 11, 2022

NoMercy235 commented Aug 3, 2022

wagnermaciel commented Aug 3, 2022

wagnermaciel left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 4, 2022

volvachev commented Mar 23, 2022 •

edited by andrewseguin

Loading