Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): throw error when thumb is missing #24061

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix(material-experimental/mdc-slider): throw error when thumb is missing #24061

merged 1 commit into from
Dec 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2021

Adds a proper error when the MDC slider is missing a thumb. Currently we eventually hit a runtime error which isn't easy to debug.

Fixes #24057.

@crisbeto
fix(material-experimental/mdc-slider): throw error when thumb is missing
705fe54 
Adds a proper error when the MDC slider is missing a thumb. Currently we eventually hit a runtime error which isn't easy to debug.

Fixes angular#24057.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 6, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2021
wagnermaciel
wagnermaciel approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It might be a good idea to add a unit test for this since this validation logic is untested, but it's not a big deal if we leave it as is imo

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 6, 2021
@crisbeto
Copy link
Member Author

crisbeto commented Dec 6, 2021

I didn't add one since the other validation logic didn't have test either.

@wagnermaciel wagnermaciel merged commit 749edd8 into angular:master Dec 7, 2021
wagnermaciel pushed a commit that referenced this pull request Dec 7, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-slider): throw error when thumb is miss…
4671d87 
…ing (#24061)

Adds a proper error when the MDC slider is missing a thumb. Currently we eventually hit a runtime error which isn't easy to debug.

Fixes #24057.

(cherry picked from commit 749edd8)
This was referenced Jan 1, 2022
Closed
Open
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-slider): Experimental mat-slider throws Cannot read properties of undefined (reading '_hostElement')
2 participants
@crisbeto @wagnermaciel