Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-luxon-adapter): add option to set first day of week #24027

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

JiriBalcar
Copy link
Contributor

Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS

Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 29, 2021
@JiriBalcar
Copy link
Contributor Author

@crisbeto I created new pull request instead of #23948 because messed up rebase. Can you please re-approve?

@crisbeto
Copy link
Member

Hmm, weird, the CI still decided not to run...

@JiriBalcar
Copy link
Contributor Author

I even created new fork and I saw that for the first time contributor you need to approve to CI to run. I do not know if there is needed some label to add for first time contributor?

@crisbeto
Copy link
Member

Those checks that need approval aren't the mandatory ones. Can you try the solution mentioned here? https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

@JiriBalcar
Copy link
Contributor Author

Honestly I do not know what should I do. I do not use CircleCI for any of my repos. I do not follow any projects there with my personal account. Maybe the checks will start after you approve this PR?

@crisbeto
Copy link
Member

I've approved it, but usually the CI runs as soon as you open the PR/push something to it.

@JiriBalcar
Copy link
Contributor Author

I tried to add one more commit and it looks like the CI started running?

@JiriBalcar
Copy link
Contributor Author

@crisbeto All checks passed, only one missing is target label. Can you please add it?

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 29, 2021
@JiriBalcar
Copy link
Contributor Author

Is everything OK now? I still see:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.
1 skipped and 14 successful checks

@crisbeto
Copy link
Member

Yes, now it's fine.

@wagnermaciel
Copy link
Contributor

@crisbeto Same issue here. Can this be "target: minor" as well?

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 3, 2021
@crisbeto
Copy link
Member

crisbeto commented Dec 3, 2021

Yes, changed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants