build: prevent * expansion for static css content in ng_web_test_suite #23982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when using a `*` inside css code (e.g. `calc(... * ...)` in the typography) it will be expanded to files in the current directory (e.g. `calc ... bazel-out external ...`), which will break the tests. This PR fixes this by wrapping the variable usage with quotes.
google-cla
bot
added
the
cla: yes
|
This is not currently a problem in the angular/components codebase, but if you were to use |
josephperrott
requested review from
devversion
and removed request for
a team
devversion
approved these changes
Nov 18, 2021
devversion
added
merge safe
target: patch
andrewseguin
removed
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Jan 10, 2022
#23982) Currently when using a `*` inside css code (e.g. `calc(... * ...)` in the typography) it will be expanded to files in the current directory (e.g. `calc ... bazel-out external ...`), which will break the tests. This PR fixes this by wrapping the variable usage with quotes. (cherry picked from commit 5fcc634)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using a
*inside css code (e.g.calc(... * ...)in the typography) it will be expanded to files in the current directory (e.g.calc ... bazel-out external ...), which will break the tests. This PR fixes this by wrapping the variable usage with quotes.