perf(material/core): tree shake sanity checks #23969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Now that we don't need to think about ViewEngine, we can use `ngDevMode` to tree shake the sanity check messages.
crisbeto
force-pushed
the
core-sanity-checks-dev-mode
branch
from
fa63858
to
e787a62
Compare
devversion
approved these changes
Nov 16, 2021
jelbourn
reviewed
Nov 16, 2021
| @Optional() @Inject(MATERIAL_SANITY_CHECKS) sanityChecks: any, | ||
| @Inject(DOCUMENT) document: any, | ||
| @Optional() @Inject(MATERIAL_SANITY_CHECKS) private _sanityChecks: SanityChecks, | ||
| @Inject(DOCUMENT) private _document: Document, |
There was a problem hiding this comment.
Does the new package format eliminate the problem with typing constructor params with browser global types like Document?
There was a problem hiding this comment.
I think that it was more of a ViewEngine vs Ivy issue than with packaging. As long as we're using @Inject we should be fine.
zarend
pushed a commit
that referenced
this pull request
Nov 19, 2021
Now that we don't need to think about ViewEngine, we can use `ngDevMode` to tree shake the sanity check messages. (cherry picked from commit 738e514)
This was referenced Dec 1, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we don't need to think about ViewEngine, we can use
ngDevModeto tree shake the sanity check messages.