-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(multiple): add non-null assertions first and last #23958
Merged
mmalerba
merged 1 commit into
angular:master
from
dario-piotrowicz:query-list-first-last
Nov 15, 2021
Merged
refactor(multiple): add non-null assertions first and last #23958
mmalerba
merged 1 commit into
angular:master
from
dario-piotrowicz:query-list-first-last
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
requested review from
andrewseguin,
crisbeto,
devversion and
jelbourn
as code owners
November 11, 2021 22:33
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Nov 11, 2021
I just wanted to add:
|
dario-piotrowicz
force-pushed
the
query-list-first-last
branch
from
November 11, 2021 22:42
c5c95b1
to
9c17bc0
Compare
dario-piotrowicz
changed the title
refactor(multiple): add non-null assertion operator to first and last
refactor(multiple): add non-null assertions first and last
Nov 11, 2021
Angular's QueryList first and last can actually be `undefined`, although this is not reflected by their type (this is a current bug in Angular: angular/angular#42563) this commit adds non-null assertions to first and last references within the codebase in preparation for solving the Angular bug without causing too many breaking changes For more information see: angular/angular#43604
dario-piotrowicz
force-pushed
the
query-list-first-last
branch
from
November 11, 2021 22:44
9c17bc0
to
044d96f
Compare
crisbeto
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crisbeto
added
action: merge
The PR is ready for merge by the caretaker
merge safe
target: patch
This PR is targeted for the next patch release
labels
Nov 12, 2021
devversion
approved these changes
Nov 12, 2021
mmalerba
pushed a commit
that referenced
this pull request
Nov 15, 2021
Angular's QueryList first and last can actually be `undefined`, although this is not reflected by their type (this is a current bug in Angular: angular/angular#42563) this commit adds non-null assertions to first and last references within the codebase in preparation for solving the Angular bug without causing too many breaking changes For more information see: angular/angular#43604 (cherry picked from commit 5138328)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular's QueryList first and last can actually be
undefined
,although this is not reflected by their type
(this is a current bug in Angular: angular/angular#42563)
this commit adds non-null assertions to first and last references within the codebase
in preparation for solving the Angular bug without causing too many breaking changes
For more information see: angular/angular#43604