fix(cdk/drag-drop): last item not returned at initial index when sorting is disabled #23934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Nov 17, 2021
src/cdk/drag-drop/drop-list-ref.ts
Outdated
| @@ -299,6 +299,16 @@ export class DropListRef<T = any> { | |||
| newPositionReference = activeDraggables[newIndex + 1]; | |||
| } | |||
|
|
|||
| // If we didn't find a new position reference, it means that either the item didn't start off | |||
| // in this container, or that the item request to be inserted at the end of the list. | |||
There was a problem hiding this comment.
Suggested change
| // in this container, or that the item request to be inserted at the end of the list. | |
| // in this container, or that the item requested to be inserted at the end of the list. |
…ing is disabled Fixes a regression caused by angular#19116 where dragging the last item into another container and returning it back to the initial one would insert the item into the first index of the list, rather than the last one. The issue was caused by the fact that we relied on the item to always be inserted at the end of the list of there is no position reference, but the condition was superceded by the condition that inserts it at the beginning of the list. Fixes angular#23865.
crisbeto
force-pushed
the
23865/drag-drop-last-item-sorting-disabled
branch
from
2d14ac3
to
05f8dfb
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ing is disabled (#23934) Fixes a regression caused by #19116 where dragging the last item into another container and returning it back to the initial one would insert the item into the first index of the list, rather than the last one. The issue was caused by the fact that we relied on the item to always be inserted at the end of the list of there is no position reference, but the condition was superceded by the condition that inserts it at the beginning of the list. Fixes #23865. (cherry picked from commit e219008)
This was referenced Jan 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by #19116 where dragging the last item into another container and returning it back to the initial one would insert the item into the first index of the list, rather than the last one. The issue was caused by the fact that we relied on the item to always be inserted at the end of the list of there is no position reference, but the condition was superseded by the condition that inserts it at the beginning of the list.
Fixes #23865.