fix(material/slide-toggle): remove tabindex from host node #23891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
slide-toggle-tabindex-host
branch
from
78d4783
to
c894a82
Compare
devversion
approved these changes
Nov 4, 2021
crisbeto
force-pushed
the
slide-toggle-tabindex-host
branch
from
c894a82
to
946ba60
Compare
|
I realized that we can clean up some more code so I've pushed another change. |
The `tabindex="-1"` on the host node was causing VoicerOver to read out the slide toggle as a group and to read out the label twice. These changes remove the `tabindex` like we've done for `mat-radio` and `mat-checkbox` in the past.
crisbeto
force-pushed
the
slide-toggle-tabindex-host
branch
from
946ba60
to
3b6419d
Compare
amysorto
pushed a commit
that referenced
this pull request
Nov 9, 2021
The `tabindex="-1"` on the host node was causing VoicerOver to read out the slide toggle as a group and to read out the label twice. These changes remove the `tabindex` like we've done for `mat-radio` and `mat-checkbox` in the past. (cherry picked from commit b533e61)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tabindex="-1"on the host node was causing VoicerOver to read out the slide toggle as a group and to read out the label twice. These changes remove thetabindexlike we've done format-radioandmat-checkboxin the past.