Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-tabs): update theming api #23855

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix(material-experimental/mdc-tabs): update theming api #23855

merged 1 commit into from
Nov 2, 2021

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Oct 28, 2021 •
edited

Project import generated by Copybara.

This change originates from cl/404320409

@google-cla
Copy link

google-cla bot commented Oct 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 28, 2021
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 28, 2021
@andrewseguin andrewseguin requested a review from a team as a code owner October 28, 2021 19:51
@andrewseguin andrewseguin changed the title Project import generated by Copybara. fix(material-experimental/mdc-tabs): update theming api Oct 28, 2021
jelbourn
jelbourn approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 28, 2021
crisbeto
crisbeto reviewed Oct 29, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Oct 29, 2021
crisbeto
crisbeto approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but the build is broken now.

@andrewseguin
Copy link
Contributor Author

Re-pushed and seems to be okay now

@andrewseguin andrewseguin added merge safe action: merge The PR is ready for merge by the caretaker labels Nov 2, 2021
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 2, 2021
@jelbourn jelbourn added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Nov 2, 2021
@jelbourn jelbourn merged commit 8f167ec into master Nov 2, 2021
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
@andrewseguin @jelbourn
fix(material-experimental/mdc-tabs): update theming api (#23855)
e7a77ed 
(cherry picked from commit 8f167ec)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewseguin @jelbourn @crisbeto