Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/chips): use defaults for input bindings #23688

Merged
merged 1 commit into from
Dec 7, 2021
Merged

docs(material/chips): use defaults for input bindings #23688

merged 1 commit into from
Dec 7, 2021

Conversation

bampakoa
Copy link
Contributor

@bampakoa bampakoa commented Oct 5, 2021

Do not set the selectable and removable default values explicitly in the examples.

Do not set the `selectable` and `removable` default values explicitly in the examples.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2021
@bampakoa
Copy link
Contributor Author

bampakoa commented Oct 5, 2021

@mmalerba could you please review this PR? Thanks a lot 🙏

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe labels Nov 30, 2021
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Dec 7, 2021
@wagnermaciel wagnermaciel merged commit a4ffc5e into angular:master Dec 7, 2021
wagnermaciel pushed a commit that referenced this pull request Dec 7, 2021
Do not set the `selectable` and `removable` default values explicitly in the examples.

(cherry picked from commit a4ffc5e)
@bampakoa bampakoa deleted the chips-examples branch December 7, 2021 15:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants