Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(youtube-player): remove deprecated APIs for v13 #23520

Merged
merged 1 commit into from
Sep 17, 2021
Merged

refactor(youtube-player): remove deprecated APIs for v13 #23520

merged 1 commit into from
Sep 17, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 3, 2021

Removes the APIs that were marked for removal in v13 in the youtube-player package.

BREAKING CHANGE:

  • YouTubePlayer.createEventsBoundInZone has been removed.

@crisbeto
refactor(youtube-player): remove deprecated APIs for v13
3e8062b 
Removes the APIs that were marked for removal in v13 in the `youtube-player` package.

BREAKING CHANGE:
* `YouTubePlayer.createEventsBoundInZone` has been removed.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 3, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Sep 3, 2021
@crisbeto crisbeto requested a review from a team as a code owner September 3, 2021 05:45
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2021
josephperrott
josephperrott approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2021
@wagnermaciel
Copy link
Contributor

wagnermaciel commented Sep 17, 2021 •
edited

@jelbourn Have we started merging breaking changes yet?

Edit: Took a look through our commit history and saw that we are

@wagnermaciel wagnermaciel merged commit 7539cf2 into angular:master Sep 17, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
13.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @wagnermaciel @devversion @josephperrott