Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio/checkbox): Improve printing stylesheet #22298

Closed
felhag opened this issue Mar 20, 2021 · 2 comments
Closed

feat(radio/checkbox): Improve printing stylesheet #22298

felhag opened this issue Mar 20, 2021 · 2 comments
Labels
area: material/checkbox area: material/radio P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@felhag
Copy link
Contributor

felhag commented Mar 20, 2021

Feature Description

Not sure if this is a bug or a feature, but when printing some components the background-color isn't included. For example:

There might be more components of course.

Use Case

Use the browser print function on page containing Angular Components. Because the background-color isn't included you can't tell if a radio or checkbox is selected.

Component:
image

When printing:
image

@felhag felhag added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Mar 20, 2021
felhag pushed a commit to felhag/components that referenced this issue Mar 20, 2021
…lar#22298)

* added color-adjust for radio background-color
* added color-adjust for checkbox background-color
felhag pushed a commit to felhag/components that referenced this issue Mar 20, 2021
felhag pushed a commit to felhag/components that referenced this issue Mar 20, 2021
felhag added a commit to felhag/components that referenced this issue Mar 20, 2021
felhag added a commit to felhag/components that referenced this issue Mar 20, 2021
@crisbeto crisbeto added area: material/checkbox area: material/radio has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Mar 22, 2021
felhag added a commit to felhag/components that referenced this issue Mar 23, 2021
felhag added a commit to felhag/components that referenced this issue Mar 23, 2021
felhag added a commit to felhag/components that referenced this issue Mar 25, 2021
…int stylesheet (angular#22298)

* added color-adjust for checkbox background-color
wagnermaciel pushed a commit that referenced this issue Mar 30, 2021
…) (#22299)

* feat(material/radio): show background-color in print stylesheet (#22298)

* added color-adjust for radio background-color

* feat(material/checkbox): show background-color in print stylesheet (#22298)  

* added color-adjust for checkbox background-color

* feat(material-experimental/mdc-checkbox): show background-color in print stylesheet (#22298) 

* added color-adjust for checkbox background-color
wagnermaciel pushed a commit that referenced this issue Mar 30, 2021
…) (#22299)

* feat(material/radio): show background-color in print stylesheet (#22298)

* added color-adjust for radio background-color

* feat(material/checkbox): show background-color in print stylesheet (#22298)

* added color-adjust for checkbox background-color

* feat(material-experimental/mdc-checkbox): show background-color in print stylesheet (#22298)

* added color-adjust for checkbox background-color

(cherry picked from commit 5fd431f)
@crisbeto
Copy link
Member

Closing since the related PR was just merged in.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/checkbox area: material/radio P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

2 participants