Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/table): add element offsets to sticky styler state #21886

Merged
merged 1 commit into from Feb 23, 2021
Merged

feat(cdk/table): add element offsets to sticky styler state #21886

merged 1 commit into from Feb 23, 2021

Conversation

MichaelJamesParsons
Copy link
Collaborator

Adds the offsets of sticky elements to the StickyUpdate interface. This change is necessary for the virtual scroll table to compute the relative position of sticky header/footers (#21708).

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2021
@MichaelJamesParsons MichaelJamesParsons added area: cdk/table G This is is related to a Google internal issue labels Feb 12, 2021
jelbourn
jelbourn approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Feb 17, 2021
@andrewseguin andrewseguin merged commit c42ece3 into angular:master Feb 23, 2021
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/table cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelJamesParsons @jelbourn @andrewseguin