Skip to content

bug(mat-menu): In high contrast mode, borders not fully visible around mat-menu-items #21524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dwaynelavon opened this issue Jan 8, 2021 · 1 comment · Fixed by #21527
Closed

bug(mat-menu): In high contrast mode, borders not fully visible around mat-menu-items #21524

dwaynelavon opened this issue Jan 8, 2021 · 1 comment · Fixed by #21527
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@dwaynelavon
Copy link

Reproduction

Stackblitz: https://stackblitz.com/angular/ooebrkdoyjb?file=src/app/menu-overview-example.html

Steps to reproduce:

  1. Enable Windows high contrast mode in settings
  2. Open firefox
  3. Create a mat-menu with 3+ options (Stackblitz above)
  4. Open the menu and navigate through the options

Expected Behavior

What behavior were you expecting to see?
Both the top and bottom borders should be visible around menu items.

Actual Behavior

What behavior did you actually see?
Only the last item shows both borders. The other items only show one border when active.

Environment

  • Angular: 11.0.3
  • CDK/Material: 11.0.3
  • Browser(s): Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

image
@dwaynelavon dwaynelavon added the needs triage This issue needs to be triaged by the team label Jan 8, 2021
@crisbeto crisbeto self-assigned this Jan 9, 2021
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) area: material/menu has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Jan 9, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 9, 2021
@crisbeto
fix(material/menu): focus indication rendering partially in high cont…
e338265 
…rast mode

Firefox seems to have an issue where the items cut off each other's outline in high contrast
mode. These changes work around the issue by introducing a slight margin.

Note that this isn't ideal, because the whole point of using an outline is so that the layout
isn't different on high contrast mode. The alternate approach is to use a `border`, but it
will cause the element to move around as the user is navigating.

Fixes angular#21524.
@crisbeto crisbeto mentioned this issue Jan 9, 2021
Merged
mmalerba pushed a commit that referenced this issue Jan 14, 2021
@crisbeto
fix(material/menu): focus indication rendering partially in high cont…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bf34cdb 
…rast mode (#21527)

Firefox seems to have an issue where the items cut off each other's outline in high contrast
mode. These changes work around the issue by introducing a slight margin.

Note that this isn't ideal, because the whole point of using an outline is so that the layout
isn't different on high contrast mode. The alternate approach is to use a `border`, but it
will cause the element to move around as the user is navigating.

Fixes #21524.
mmalerba pushed a commit that referenced this issue Jan 14, 2021
@crisbeto @mmalerba
fix(material/menu): focus indication rendering partially in high cont…
e180655 
…rast mode (#21527)

Firefox seems to have an issue where the items cut off each other's outline in high contrast
mode. These changes work around the issue by introducing a slight margin.

Note that this isn't ideal, because the whole point of using an outline is so that the layout
isn't different on high contrast mode. The alternate approach is to use a `border`, but it
will cause the element to move around as the user is navigating.

Fixes #21524.

(cherry picked from commit bf34cdb)
mmalerba pushed a commit that referenced this issue Jan 14, 2021
@crisbeto @mmalerba
fix(material/menu): focus indication rendering partially in high cont…
e029ea8 
…rast mode (#21527)

Firefox seems to have an issue where the items cut off each other's outline in high contrast
mode. These changes work around the issue by introducing a slight margin.

Note that this isn't ideal, because the whole point of using an outline is so that the layout
isn't different on high contrast mode. The alternate approach is to use a `border`, but it
will cause the element to move around as the user is navigating.

Fixes #21524.

(cherry picked from commit bf34cdb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/menu P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/menu): focus indication rendering partially in high contrast mode crisbeto/material2
2 participants
@crisbeto @dwaynelavon