Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(select): Down-arrow doesn't display in High Contrast mode #21263

Closed
lukeschaefer opened this issue Dec 9, 2020 · 3 comments
Closed

bug(select): Down-arrow doesn't display in High Contrast mode #21263

lukeschaefer opened this issue Dec 9, 2020 · 3 comments
Labels
Accessibility This issue is related to accessibility (a11y) area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@lukeschaefer
Copy link

Reproduction

This bug can be replicated in the example documentation itself:
https://material.angular.io/components/select/examples

Steps to reproduce:

  1. In Windows, turn on High-Contrast mode
  2. Open the examples in Firefox (chrome doesn't work with Windows High Contrast mode)

Expected Behavior

The down-arrow on the right side of the select box should be visible

Actual Behavior

Instead, it looks like a flat line

Environment

  • Angular:
  • CDK/Material:
  • Browser(s): Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@lukeschaefer lukeschaefer added the needs triage This issue needs to be triaged by the team label Dec 9, 2020
@lukeschaefer lukeschaefer reopened this Dec 9, 2020
@crisbeto
Copy link
Member

crisbeto commented Dec 9, 2020

There's a PR for this already, but it wasn't marked as high priority so we never got around to merging it in. #14219

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Dec 14, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 15, 2021
@crisbeto
fix(material-experimental/mdc-select): arrow not rendering in high co…
f6aa10e 
…ntrast mode

The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in
high contrast mode. These changes switch it to an SVG arrow.

These changes are identical to angular#14219 which had some trouble landing due to screenshot
diffs. The MDC select shouldn't have such issues.

Relates to angular#21263.
@crisbeto crisbeto mentioned this issue Jan 15, 2021
Merged
annieyw pushed a commit that referenced this issue Mar 7, 2021
@crisbeto
fix(material-experimental/mdc-select): arrow not rendering in high co…
fef9179 
…ntrast mode (#21606)

The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in
high contrast mode. These changes switch it to an SVG arrow.

These changes are identical to #14219 which had some trouble landing due to screenshot
diffs. The MDC select shouldn't have such issues.

Relates to #21263.
annieyw pushed a commit that referenced this issue Mar 7, 2021
@crisbeto @annieyw
fix(material-experimental/mdc-select): arrow not rendering in high co…
0f333a2 
…ntrast mode (#21606)

The MDC select uses a CSS triangle for its down arrow which renders as a rectangle in
high contrast mode. These changes switch it to an SVG arrow.

These changes are identical to #14219 which had some trouble landing due to screenshot
diffs. The MDC select shouldn't have such issues.

Relates to #21263.

(cherry picked from commit fef9179)
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
@annieyw
Copy link
Contributor

annieyw commented Apr 21, 2021

duplicate of #14207

@annieyw annieyw closed this as completed Apr 21, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) area: material/select P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crisbeto @lukeschaefer @annieyw