Skip to content

bug(mat-date-range-input): Date range input always uses default error state matcher #21205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MursalovAltun opened this issue Dec 3, 2020 · 1 comment · Fixed by #21210
Closed

bug(mat-date-range-input): Date range input always uses default error state matcher #21205

MursalovAltun opened this issue Dec 3, 2020 · 1 comment · Fixed by #21210
Assignees
@crisbeto
Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@MursalovAltun
Copy link

Reproduction

Reproduction on stackblitz

Steps to reproduce:

  1. Focus in date range picker input
  2. Focus out

Expected Behavior

Expected date range picker input to not be shown as invalid

Actual Behavior

Date range picker does not use custom ErrorStateMatcher instead uses own _defaultErrorStateMatcher as errorStateMatcher and displays input as invalid

Environment

  • Angular: 10
  • CDK/Material: 10
  • Browser(s): Google Chrome Version 87.0.4280.66 (Official Build) (64-bit)
  • Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu
@MursalovAltun MursalovAltun added the needs triage This issue needs to be triaged by the team label Dec 3, 2020
@crisbeto crisbeto self-assigned this Dec 3, 2020
@crisbeto crisbeto added area: material/datepicker has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Dec 3, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 3, 2020
@crisbeto
fix(material/datepicker): unable to pass in errorStateMatcher through…
6656870 
… binding on range input

Fixes that the `errorStateMatcher` on the date range inputs wasn't marked as an
`Input` which made it impossible to change.

Fixes angular#21205.
@crisbeto crisbeto mentioned this issue Dec 3, 2020
Merged
annieyw pushed a commit that referenced this issue Jan 9, 2021
@crisbeto
fix(material/datepicker): unable to pass in errorStateMatcher through…
8f0e654 
… binding on range input (#21210)

Fixes that the `errorStateMatcher` on the date range inputs wasn't marked as an
`Input` which made it impossible to change.

Fixes #21205.
annieyw pushed a commit that referenced this issue Jan 9, 2021
@crisbeto @annieyw
fix(material/datepicker): unable to pass in errorStateMatcher through…
421a849 
… binding on range input (#21210)

Fixes that the `errorStateMatcher` on the date range inputs wasn't marked as an
`Input` which made it impossible to change.

Fixes #21205.

(cherry picked from commit 8f0e654)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(material/datepicker): unable to pass in errorStateMatcher through…
6765590 
… binding on range input (angular#21210)

Fixes that the `errorStateMatcher` on the date range inputs wasn't marked as an
`Input` which made it impossible to change.

Fixes angular#21205.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @MursalovAltun