Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump deps for 9.0.0 #18415

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Feb 6, 2020

No description provided.

@jelbourn jelbourn added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 6, 2020
@jelbourn jelbourn requested a review from a team as a code owner February 6, 2020 18:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2020
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn please remove ^ from the lines which didn't previously have them. otherwise lgtm. thanks

@IgorMinar
Copy link
Contributor

oh, I thought this was @angular/angular repo :) I'll let you decided what to do with ^, but for these particular packages it's often better to be explicit to prevent version misalignment, unless we have renovate/pullpanda updating them automatically in this repo.

@jelbourn
Copy link
Member Author

jelbourn commented Feb 6, 2020

We generally use them; yarn.lock prevents them from drifting

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 6, 2020
@jelbourn jelbourn merged commit 7c348bc into angular:9.0.x Feb 6, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants