fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly #14722

crisbeto · 2019-01-04T13:25:15Z

Fixes not being able to override the elevation of a button toggle. Similar to fix(button-toggle): allow toggle group elevation to be overwritten #7909, but avoids issues with the new appearance.
Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing.

jelbourn

LGTM

…ntrast styling applied incorrectly * Fixes not being able to override the elevation of a button toggle. Similar to angular#7909, but makes avoids issues with the new appearance. * Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing. Fixes angular#14721.

…ntrast styling applied incorrectly (#14722) * Fixes not being able to override the elevation of a button toggle. Similar to #7909, but makes avoids issues with the new appearance. * Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing. Fixes #14721. (cherry picked from commit b703cb3)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.3/13.2.4) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.3` -> `13.2.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.3/13.2.4) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1324-plastic-mug-2022-02-23) [Compare Source](angular/components@13.2.3...13.2.4) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [74bae85bc5](angular/components@74bae85) | fix | **drag-drop:** incorrectly sorting element inside dialog with blocked scrolling ([#14806](angular/components#14806)) | | [81898ca5f6](angular/components@81898ca) | fix | **drag-drop:** stop pointer events on placeholder ([#24404](angular/components#24404)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [6b76469b4a](angular/components@6b76469) | fix | **autocomplete:** closing immediately when input is focused programmatically ([#21081](angular/components#21081)) | | [3ea76419c8](angular/components@3ea7641) | fix | **autocomplete:** use narrow value for aria-haspopup ([#15361](angular/components#15361)) | | [9a12eabf6b](angular/components@9a12eab) | fix | **button-toggle:** unable to override elevation and high contrast styling applied incorrectly ([#14722](angular/components#14722)) | | [cbd4b0ce4f](angular/components@cbd4b0c) | fix | **checkbox:** clear static aria attributes from host nodes ([#17092](angular/components#17092)) | | [f6eaa7c1cf](angular/components@f6eaa7c) | fix | **form-field:** use correct color for form fields in high contrast mode ([#24422](angular/components#24422)) | | [39d7834797](angular/components@39d7834) | fix | **radio:** clicks not propagating to wrapper elements ([#24459](angular/components#24459)) | | [5988b8f77b](angular/components@5988b8f) | fix | **radio:** not checked on first click if partially visible ([#19505](angular/components#19505)) | | [33716f124b](angular/components@33716f1) | fix | **select:** arrow highlighted state not updating in Safari ([#15281](angular/components#15281)) | | [fc204e4f4d](angular/components@fc204e4) | fix | **sidenav:** prevent focus from entering hidden sidenav if child element has a visibility | | [5e41a0ad09](angular/components@5e41a0a) | fix | **tabs:** use buttons for paginator also tab-header and mdc ([#24338](angular/components#24338)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [4198f5b5dc](angular/components@4198f5b) | fix | **mdc-dialog:** align change detection with non-MDC version ([#24451](angular/components#24451)) | | [45836f924d](angular/components@45836f9) | fix | **mdc-list:** fix typo in action-list css class ([#24448](angular/components#24448)) | | [7ca02495cd](angular/components@7ca0249) | fix | **mdc-list:** use body-1 rather than subtitle-1 typography for list items ([#24417](angular/components#24417)) | | [c9a15476e8](angular/components@c9a1547) | fix | **mdc-select:** target correct element with typography ([#24258](angular/components#24258)) | | [bd3f39fb15](angular/components@bd3f39f) | perf | **mdc-table:** reduce bundle size ([#24309](angular/components#24309)) | #### Special Thanks Alireza Ebrahimkhani, Arthur Ming, Jeri Peier, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner and renovate\[bot]  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1188 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-03-23T00:03:28Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added the target: patch This PR is targeted for the next patch release label Jan 4, 2019

crisbeto assigned jelbourn Jan 4, 2019

crisbeto requested a review from jelbourn as a code owner January 4, 2019 13:25

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 4, 2019

crisbeto mentioned this pull request Jan 4, 2019

fix(button-toggle): allow toggle group elevation to be overwritten #7909

Closed

jelbourn approved these changes Jan 9, 2019

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019

jelbourn added ༼ つ ◕_◕ ༽つ and removed ༼ つ ◕_◕ ༽つ labels Apr 25, 2019

mmalerba added aaa and removed aaa labels Apr 25, 2019

andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019

crisbeto force-pushed the 14721/button-toggle-overlay-border branch from e6ba9d3 to f5e5465 Compare July 27, 2019 11:29

crisbeto force-pushed the 14721/button-toggle-overlay-border branch from f5e5465 to c39a782 Compare February 10, 2020 20:44

crisbeto force-pushed the 14721/button-toggle-overlay-border branch from c39a782 to 01f4386 Compare June 2, 2020 20:13

mmalerba removed the lgtm label Jul 31, 2020

crisbeto changed the title ~~fix(button-toggle): unable to override elevation and high contrast styling applied incorrectly~~ fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly May 7, 2021

crisbeto force-pushed the 14721/button-toggle-overlay-border branch from 01f4386 to 0a23dff Compare May 7, 2021 06:09

crisbeto force-pushed the 14721/button-toggle-overlay-border branch from 0a23dff to cda2629 Compare May 7, 2021 06:12

andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021

andrewseguin merged commit b703cb3 into angular:master Feb 20, 2022

This was referenced Feb 25, 2022

build(deps): bump @angular/cdk from 12.2.4 to 13.2.4 numbersprotocol/capture-lite#1311

Closed

build(deps): bump @angular/material from 12.2.4 to 13.2.4 numbersprotocol/capture-lite#1330

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly #14722

fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly #14722

crisbeto commented Jan 4, 2019 •

edited

jelbourn left a comment

angular-automatic-lock-bot bot commented Mar 23, 2022

fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly #14722

fix(material/button-toggle): unable to override elevation and high contrast styling applied incorrectly #14722

Conversation

crisbeto commented Jan 4, 2019 • edited

jelbourn left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Mar 23, 2022

crisbeto commented Jan 4, 2019 •

edited