Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Event vs KeyboardEvent #885

Open
LucasSloan opened this issue May 28, 2019 · 0 comments
Open

Event vs KeyboardEvent #885

LucasSloan opened this issue May 28, 2019 · 0 comments
Labels

Comments

@LucasSloan
Copy link
Contributor

I saw 2 instances of this error, there might be more. Basically, the Closure type system has much broader base types than the TypeScript type system. So in Closure, the type Event had all the properties of the TypeScript type KeyboardEvent. Gents translated the type to just Event, so it had to be manually changed to the more precise KeyboardEvent. There was a similar issue with Element and HTMLElement.

I think the fix is to introduce ClosureEvent and ClosureElement types that match the actual types of the Closure Event and Element (and probably more built-ins).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant