From 6c5b16f89ac49809b79e4e4101314a70a23e96d3 Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Thu, 29 Apr 2021 12:11:43 -0700 Subject: [PATCH] ci: changes to `packages/common/http` should not require `fw-common` approval Currently when the change is made to the code inside the `packages/common/http` folder, both `fw-http` and `fw-common` group members are assigned for review. However only `fw-http` is required and should be sufficient. This commit updates the PullApprove config to exclude `packages/common/http` path from the list of folders that `fw-common` "owns". --- .pullapprove.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 9b689d585271b..58036d43c5001 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -444,7 +444,7 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - > - contains_any_globs(files.exclude("packages/core/schematics/**"), [ + contains_any_globs(files.exclude("packages/core/schematics/**").exclude("packages/common/http/**"), [ 'packages/common/**', 'packages/examples/common/**', ])