From 8aba98c29600001377c727dc3ad84ac5ed60afe6 Mon Sep 17 00:00:00 2001 From: Basheer Ahmed Date: Thu, 12 Nov 2020 14:34:40 +0500 Subject: [PATCH 1/2] fix: replace copy of query selector node list from "spread(...)" to "for" to avoid callstack error --- packages/animations/browser/src/render/shared.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/animations/browser/src/render/shared.ts b/packages/animations/browser/src/render/shared.ts index 40d9085a950ce..06df464c55f05 100644 --- a/packages/animations/browser/src/render/shared.ts +++ b/packages/animations/browser/src/render/shared.ts @@ -183,12 +183,13 @@ if (_isNode || typeof Element !== 'undefined') { _query = (element: any, selector: string, multi: boolean): any[] => { let results: any[] = []; if (multi) { - results.push(...element.querySelectorAll(selector)); + const elems = element.querySelectorAll(selector); + for(let i = 0; i < elems.length; i++) { + results.push(elems[i]); + } } else { const elm = element.querySelector(selector); - if (elm) { - results.push(elm); - } + results = elm ? [elm] : []; } return results; }; From 3af19bb0d498534c2508cdf45d56804223f6f78c Mon Sep 17 00:00:00 2001 From: Basheer Ahmed Date: Thu, 12 Nov 2020 14:36:29 +0500 Subject: [PATCH 2/2] fix spacing --- packages/animations/browser/src/render/shared.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/animations/browser/src/render/shared.ts b/packages/animations/browser/src/render/shared.ts index 06df464c55f05..683c009424da6 100644 --- a/packages/animations/browser/src/render/shared.ts +++ b/packages/animations/browser/src/render/shared.ts @@ -184,7 +184,7 @@ if (_isNode || typeof Element !== 'undefined') { let results: any[] = []; if (multi) { const elems = element.querySelectorAll(selector); - for(let i = 0; i < elems.length; i++) { + for (let i = 0; i < elems.length; i++) { results.push(elems[i]); } } else {