New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): add URLSearchParams to request body #37852
Conversation
@gkalpak another size flake |
@alxhub how to get rid of the error in legacy-unit-tests-saucelabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is actually a duplicate of #37767, which arrived just before this one. Thanks for the contribution @ajitsinghkaler. |
Hi @ajitsinghkaler - #37767 never got updated, so I am re-opening this one. Are you interested in trying to land it? |
@petebacondarwin I'm interested can you tell me why ci is failing I think its because tests are not working in legacy browser Can you tell me how to disable it on legacy browsers? Or if there is anything else |
The failing tests are probably flakes. I tried restarting them but I think the PR is too old. |
Yeah sure |
URLSearch params are by default supported in the browser but are not supported by angular/http package added support for URLSearchParams Fixes angular#36317
2f75035
to
d0088be
Compare
@petebacondarwin rebased it |
Caretaker: I have marked with both presubmit and merge because I am confident that this will sail through G3. |
URLSearch params are by default supported in the browser but are not supported by angular/http package added support for URLSearchParams
Fixes #36317
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No support for URL searchParams
Issue Number: 36317
What is the new behavior?
Support for URL searchParams
Does this PR introduce a breaking change?
Other information