Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(routing): fix repeated note in "Add an Input to the component" section #55262

Closed
wants to merge 1 commit into from

Conversation

MoIbrahim10
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Removed repeated lines in the "Add an Input to the component " section
Copy link

google-cla bot commented Apr 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from jelbourn April 9, 2024 12:51
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we'll need to remove the 2nd one as we're matching on the uppercase NOTE to create the note layout.

Also can you remove the extra </docs-step>, thank you.

@pkozlowski-opensource pkozlowski-opensource added the area: adev Angular.dev documentation label Apr 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 11, 2024
@MoIbrahim10 MoIbrahim10 deleted the patch-1 branch April 11, 2024 18:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: adev Angular.dev documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants