Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(http): Mark the http tests as flaky because of one particular… #55255

Closed
wants to merge 1 commit into from
Closed

build(http): Mark the http tests as flaky because of one particular… #55255

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

… transferCache test.

There is one particular transfer cache test that seldom fails. Let's mark it as flaky for now as this issue is non-obvious.

cc @josephperrott, can you confirm that this will re-run the tests if they fails ?

@JeanMeche
build(http): Mark the http tests as flaky because of one particular…
4f8928f 
… transferCache test.

There is one particular transfer cache test that seldom fails. Let's mark it as flaky for now as this issue is non-obvious.
@pullapprove pullapprove bot requested a review from atscott April 8, 2024 23:47
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 8, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 8, 2024
AndrewKushnir
AndrewKushnir approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming we have the necessary setup for FW tests to retry on CI) 👍

@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Apr 9, 2024
josephperrott
josephperrott approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Apr 11, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from atscott April 11, 2024 18:49
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit ab910e2.

pkozlowski-opensource pushed a commit that referenced this pull request Apr 11, 2024
@JeanMeche @pkozlowski-opensource
build(http): Mark the http tests as flaky because of one particular…
051c140 
… transferCache test. (#55255)

There is one particular transfer cache test that seldom fails. Let's mark it as flaky for now as this issue is non-obvious.

PR Close #55255
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 11, 2024
@JeanMeche @iteriani
build(http): Mark the http tests as flaky because of one particular…
f9a00bf 
… transferCache test. (angular#55255)

There is one particular transfer cache test that seldom fails. Let's mark it as flaky for now as this issue is non-obvious.

PR Close angular#55255
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JeanMeche @pkozlowski-opensource @josephperrott @AndrewKushnir @atscott