New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Synchronize changes from internal JSAction codebase. #55182
Conversation
0a658aa
to
eea9e6c
Compare
eea9e6c
to
cd8f7ca
Compare
1: Remove USE_EVENT_PATH, which has no users. 2: Create a new `EventActionInfo` object to represent actions, update all `EventInfoWrapper` users. 3: Fix `stopPropagation` behavior in JSAction Dispatcher - it should only `stopPropagation` if an action is found, which is only known during normal dispatch rather than global.
cd8f7ca
to
d4c3625
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many licks does it take to get to the center of a tootsie pop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: primitives-event-dispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: primitives-event-dispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: primitives
@mturco could you please leave a review with the "Reviewed-for: primitives-shared" comment? That should complete the set of required LGTMs for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: primitives-shared
Caretaker note: This isn't in use yet in G3. So we can merge this without a TGP. |
This PR was merged into the repository by commit 1ee9f32. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
1: Remove USE_EVENT_PATH, which has no users.
2: Create a new
EventActionInfo
object to represent actions, update allEventInfoWrapper
users.3: Fix
stopPropagation
behavior in JSAction Dispatcher - it should onlystopPropagation
if an action is found, which is only known during normal dispatch rather than global.4: Update the internal
EventInfo
representation of anActionInfo
to match the external representation inEventInfoWrapper
.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information