Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Synchronize changes from internal JSAction codebase. #55182

Closed
wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

@iteriani iteriani commented Apr 2, 2024

1: Remove USE_EVENT_PATH, which has no users.

2: Create a new EventActionInfo object to represent actions, update all EventInfoWrapper users.

3: Fix stopPropagation behavior in JSAction Dispatcher - it should only stopPropagation if an action is found, which is only known during normal dispatch rather than global.

4: Update the internal EventInfo representation of an ActionInfo to match the external representation in EventInfoWrapper.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [X ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

Other information

@pullapprove pullapprove bot requested a review from crisbeto April 2, 2024 21:46
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 2, 2024
@jessicajaniuk jessicajaniuk added the area: core Issues related to the framework runtime label Apr 2, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 2, 2024
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 2, 2024
@jessicajaniuk jessicajaniuk added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 3, 2024
@jessicajaniuk jessicajaniuk removed the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 3, 2024
@iteriani iteriani marked this pull request as draft April 4, 2024 18:49
@iteriani iteriani marked this pull request as ready for review April 4, 2024 18:50
@iteriani iteriani requested a review from crisbeto April 4, 2024 18:52
1: Remove USE_EVENT_PATH, which has no users.

2: Create a new `EventActionInfo` object to represent actions, update all `EventInfoWrapper` users.

3: Fix `stopPropagation` behavior in JSAction Dispatcher - it should only `stopPropagation` if an action is found, which is only known during normal dispatch rather than global.
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 8, 2024
Copy link
Contributor

@tbondwilkinson tbondwilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many licks does it take to get to the center of a tootsie pop.

#3

@pullapprove pullapprove bot requested a review from mturco April 8, 2024 21:17
Copy link
Contributor

@tbondwilkinson tbondwilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: primitives-event-dispatch

Copy link

@mturco mturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: primitives-event-dispatch

@pullapprove pullapprove bot requested a review from mturco April 8, 2024 22:59
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: primitives

@AndrewKushnir
Copy link
Contributor

@mturco could you please leave a review with the "Reviewed-for: primitives-shared" comment? That should complete the set of required LGTMs for this PR.

Copy link

@mturco mturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: primitives-shared

@AndrewKushnir AndrewKushnir removed the request for review from dylhunn April 8, 2024 23:06
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 8, 2024
@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2024
@thePunderWoman thePunderWoman removed action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime labels Apr 10, 2024
@ngbot ngbot bot removed this from the Backlog milestone Apr 10, 2024
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label Apr 10, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 10, 2024
@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2024
@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 10, 2024
@thePunderWoman
Copy link
Contributor

Caretaker note: This isn't in use yet in G3. So we can merge this without a TGP.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 1ee9f32.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants