Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update private exports #55103

Closed
wants to merge 2 commits into from
Closed

Update private exports #55103

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 28, 2024

Angular recently gained a local compilation mode (see commit 345dd6d). This is intended to be used with the TypeScript compiler option isolatedModules, which bans imports of const enums.

@atscott atscott added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Mar 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 28, 2024
@atscott atscott changed the title refactor(core): Update SchedulingMode to be regular enum Update private exports Mar 28, 2024
@atscott
refactor(core): Update SchedulingMode to be regular enum
800e750 
Angular recently gained a local compilation mode (see commit 345dd6d).
This is intended to be used with the TypeScript compiler option isolatedModules, which bans imports of const enums.
@atscott
refactor(core): Move private export testing file to src
124e0bf 
This matches the private export approach for files in other packages.
@atscott atscott requested a review from dylhunn March 28, 2024 22:43
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2024
@ngbot
Copy link

ngbot bot commented Mar 28, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott closed this in ac0a51c Mar 28, 2024
@atscott
Copy link
Contributor Author

atscott commented Mar 28, 2024

This PR was merged into the repository by commit 0b450ff.

atscott added a commit that referenced this pull request Mar 28, 2024
@atscott
refactor(core): Move private export testing file to src (#55103)
0b450ff 
This matches the private export approach for files in other packages.

PR Close #55103
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@atscott @ilirbeqirii
refactor(core): Update SchedulingMode to be regular enum (angular#55103)
669b4cd 
Angular recently gained a local compilation mode (see commit 345dd6d).
This is intended to be used with the TypeScript compiler option isolatedModules, which bans imports of const enums.

PR Close angular#55103
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@atscott @ilirbeqirii
refactor(core): Move private export testing file to src (angular#55103)
be19022 
This matches the private export approach for files in other packages.

PR Close angular#55103
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atscott @dylhunn