Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): test cleanup should not throw if Zone is not present #55096

Closed
wants to merge 1 commit into from
Closed

fix(core): test cleanup should not throw if Zone is not present #55096

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 28, 2024

The test hooks should not throw if applications choose not to load ZoneJS.

fixes #48198

@atscott atscott added area: testing Issues related to Angular testing features, such as TestBed area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Mar 28, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 28, 2024
@atscott atscott requested a review from crisbeto March 28, 2024 17:22
crisbeto
crisbeto approved these changes Mar 28, 2024
View reviewed changes
packages/core/testing/src/fake_async.ts Outdated Show resolved Hide resolved
@atscott atscott force-pushed the dontthrowoncleanup branch 2 times, most recently from 324a313 to c21daf8 Compare March 28, 2024 18:03
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2024
@atscott
fix(core): test cleanup should not throw if Zone is not present
2a37275 
The test hooks should not throw if applications choose not to load ZoneJS.

fixes angular#48198
@atscott atscott closed this in 914e453 Mar 28, 2024
atscott added a commit that referenced this pull request Mar 28, 2024
@atscott
fix(core): test cleanup should not throw if Zone is not present (#55096)
4d04399 
The test hooks should not throw if applications choose not to load ZoneJS.

fixes #48198

PR Close #55096
@atscott
Copy link
Contributor Author

atscott commented Mar 28, 2024

This PR was merged into the repository by commit 914e453.

ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@atscott @ilirbeqirii
fix(core): test cleanup should not throw if Zone is not present (angu…
9c145dd 
…lar#55096)

The test hooks should not throw if applications choose not to load ZoneJS.

fixes angular#48198

PR Close angular#55096
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

TestBed should be zoneless compatible
2 participants
@atscott @crisbeto