fix(language-service): avoid generating TS syntactic diagnostics for templates #55091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…templates Angular's template files are not valid TypeScript. Attempting to get syntactic diagnostics from the underlying TypeScript language service will result in a large amount of false positive errors. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for syntactic errors.
clydin
added
target: major
atscott
approved these changes
Mar 28, 2024
atscott
reviewed
Mar 28, 2024
clydin
added
the
merge: squash commits
atscott
added
action: merge
|
This PR was merged into the repository by commit a48afe0. |
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…templates (angular#55091) Angular's template files are not valid TypeScript. Attempting to get syntactic diagnostics from the underlying TypeScript language service will result in a large amount of false positive errors. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for syntactic errors. PR Close angular#55091
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular's template files are not valid TypeScript. Attempting to get syntactic diagnostics from the underlying TypeScript language service will result in a large amount of false positive errors. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for syntactic errors.