Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: drop glossary links #55044

Closed
wants to merge 1 commit into from
Closed

docs: drop glossary links #55044

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 26, 2024 •
edited

There is no glossary anymore on ADEV.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2024
@JeanMeche JeanMeche marked this pull request as ready for review March 26, 2024 21:55
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 27, 2024
bencodezen
bencodezen approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the glossary references @JeanMeche!

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2024
sonukapoor
sonukapoor approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Deja vu? I thought I had already reviewed this.

@atscott
Copy link
Contributor

atscott commented Mar 28, 2024

This PR was merged into the repository by commit f523415.

@atscott atscott closed this in f523415 Mar 28, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@JeanMeche @ilirbeqirii
docs: drop glossary links (angular#55044)
21d5cde 
PR Close angular#55044
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonukapoor sonukapoor sonukapoor approved these changes

@bencodezen bencodezen bencodezen approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeanMeche @atscott @sonukapoor @bencodezen