New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 17.3 ngOnInit running infinite loop with defer block #55036
Comments
Please provide a runnable reproduction, either in a Github repository or Stackblitz. |
Done! Not sure if you can see the code and replicate the issue.. Here is what I managed to put onto Stackblitz |
@dreamstar-enterprises Thank you for the reproduction. @AndrewKushnir I simplified the reproduction quite a bit here: https://stackblitz.com/edit/stackblitz-starters-bmouvm. This seems pretty similar to #54864 where a component with |
@dreamstar-enterprises I've confirmed that the root cause of this issue is the same as the one in #54864. We are working on a fix and I'll share an update once the fix is available. |
Thank you! I really, really appreciate it. (I'll try to roll back to 17.01 if I can in the meantime) |
…ocks This commit updates the `@defer` logic to establish proper injector resolution order. More specifically: - Makes node injectors to be inspected first, similar to how it happens when `@defer` block is not used. - Adds extra handling for the Router's `OutletInjector`, until we replace it with an `EnvironmentInjector`. Resolves angular#54864. Resolves angular#55028. Resolves angular#55036.
…ocks (#55079) This commit updates the `@defer` logic to establish proper injector resolution order. More specifically: - Makes node injectors to be inspected first, similar to how it happens when `@defer` block is not used. - Adds extra handling for the Router's `OutletInjector`, until we replace it with an `EnvironmentInjector`. Resolves #54864. Resolves #55028. Resolves #55036. PR Close #55079
Thank you. The issue seems closed now. Do you know how I, myself, could get the changes. Or do I have to wait for the next published release? |
There will be a release later today that includes the fix. |
Quick update: the fix for this issue was merged and released as a part of Angular v17.3.2 (available on NPM). Please let us know if you still see the issue after updating to v17.3.2. |
Its fixed! Works great! (like it did with 17.0.1). Thank you very much for listening to my request, and investigating / attacking the problem! I'm very grateful! |
…ocks (angular#55079) This commit updates the `@defer` logic to establish proper injector resolution order. More specifically: - Makes node injectors to be inspected first, similar to how it happens when `@defer` block is not used. - Adds extra handling for the Router's `OutletInjector`, until we replace it with an `EnvironmentInjector`. Resolves angular#54864. Resolves angular#55028. Resolves angular#55036. PR Close angular#55079
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
Yes
Description
Full documentation of issue here >>
https://stackoverflow.com/questions/78216445/angular-ngoninit-running-multipe-times-resulting-in-call-stack-error-with-sign
Wasn't a problem with Angular 17.01...
Please provide a link to a minimal reproduction of the bug
https://stackoverflow.com/questions/78216445/angular-ngoninit-running-multipe-times-resulting-in-call-stack-error-with-sign
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: