-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler-cli): move config initialization into constructor #54975
Conversation
LGTM. @frost-cy can you please run |
I'm not sure if it worked. |
@frost-cy I'm trying to fix this PR up for you, but I recommend having a look at these slides for future PRs. The formatting is not correct because you likely just used the Github web UI |
refactor(compiler-cli): move config initialization into constructor
…uctor Fix formatting
This PR was merged into the repository by commit 0a8c48e. |
…ngular#54975) refactor(compiler-cli): move config initialization into constructor PR Close angular#54975
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When TS output target is set to ES2022 or newer, the class fields don't get transpiled.
That causes a runtime error here in the
this._config.generateUniqueIdentifier
.This is because
_config
doesn't get set until the constructor runs.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No change
Issue Number: N/A
What is the new behavior?
No change
Does this PR introduce a breaking change?
Other information