Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler-cli): move config initialization into constructor #54975

Closed
wants to merge 2 commits into from

Conversation

frost-cy
Copy link
Contributor

When TS output target is set to ES2022 or newer, the class fields don't get transpiled.

That causes a runtime error here in the this._config.generateUniqueIdentifier.

This is because _config doesn't get set until the constructor runs.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No change

Issue Number: N/A

What is the new behavior?

No change

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@frost-cy frost-cy marked this pull request as ready for review March 20, 2024 23:47
@pullapprove pullapprove bot requested a review from devversion March 20, 2024 23:47
@devversion
Copy link
Member

LGTM. @frost-cy can you please run yarn ng-dev format changed? (and fix the prettier formatting)

@devversion devversion added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews hotlist: google area: compiler Issues related to `ngc`, Angular's template compiler labels Mar 25, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 25, 2024
@devversion devversion added the target: patch This PR is targeted for the next patch release label Mar 25, 2024
@frost-cy frost-cy marked this pull request as draft April 1, 2024 22:03
@frost-cy frost-cy marked this pull request as ready for review April 1, 2024 22:04
@frost-cy frost-cy marked this pull request as draft April 1, 2024 22:19
@frost-cy frost-cy marked this pull request as ready for review April 1, 2024 22:19
@frost-cy
Copy link
Contributor Author

frost-cy commented Apr 1, 2024

LGTM. @frost-cy can you please run yarn ng-dev format changed? (and fix the prettier formatting)

I'm not sure if it worked.

@devversion
Copy link
Member

@frost-cy I'm trying to fix this PR up for you, but I recommend having a look at these slides for future PRs. The formatting is not correct because you likely just used the Github web UI

frost-cy and others added 2 commits April 10, 2024 10:05
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 10, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 0a8c48e.

pkozlowski-opensource pushed a commit that referenced this pull request Apr 11, 2024
…54975)

refactor(compiler-cli): move config initialization into constructor
PR Close #54975
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 11, 2024
…ngular#54975)

refactor(compiler-cli): move config initialization into constructor
PR Close angular#54975
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler hotlist: google target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants