Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove broken link from CONTRIBUTING.md #54953

Closed
wants to merge 1 commit into from

Conversation

allanbees
Copy link
Contributor

@allanbees allanbees commented Mar 19, 2024

Removes the broken link https://runnable.com/ from CONTRIBUTING.md and all the other links that aren't referenced.

Fixes 54948.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2024
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 19, 2024
@JeanMeche
Copy link
Member

Can you also remove the other links that aren't referenced ?

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 19, 2024
@JeanMeche
Copy link
Member

Perfect! Can you squash both commits into one, so this change is a single commit. Thank you.

@allanbees
Copy link
Contributor Author

Perfect! Can you squash both commits into one, so this change is a single commit. Thank you.

I've squashed the commits. Thanks!

@JeanMeche
Copy link
Member

Currrently the PR is made of 5 commit. With the git rebase -i HEAD~5 you should be able to drop the merge commit an squash the others.

@angular-robot angular-robot bot removed the area: docs Related to the documentation label Mar 20, 2024
@ngbot ngbot bot removed this from the Backlog milestone Mar 20, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 20, 2024
@allanbees
Copy link
Contributor Author

Currrently the PR is made of 5 commit. With the git rebase -i HEAD~5 you should be able to drop the merge commit an squash the others.

Done.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 20, 2024
@atscott
Copy link
Contributor

atscott commented Mar 28, 2024

This PR was merged into the repository by commit fac8d34.

@atscott atscott closed this in fac8d34 Mar 28, 2024
atscott pushed a commit that referenced this pull request Mar 28, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runnable.com can be removed from CONTRIBUTING.md
5 participants