New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing standalone
components declared with button[custom-button]
are not reported by the compiler
#46351
Comments
Yes, this is the "blind spot" in our template syntax. Essentially we can't know, from the syntax, if
There is a longer discussion on the topic in #3425 |
@pkozlowski-opensource Thanks for clarification. I am observing similar behaviour with sugar-style directives (*ngIf for example), is it the same reason? Example - https://stackblitz.com/edit/angular-standalone-4tmeb9?file=src%2Fmain.ts,src%2Fapp%2Fimage.component.ts EDIT: |
Yes, directives matching on even handlers (ex. The |
If it's not possible for compiler, maybe it make sense to pass this to developer? preudo code from future .angularlint
|
#46146 will be in 14.1 which adds this warning for |
I was asked to copy and paste here the description of a duplicate issue I opened (#46661), so here it goes: If a directive has an attribute selector and the attribute is used without square brackets, such as When using NgModules, such a bug happens rarely, because you rarely forget to import the router module (for example) in your main or feature module. But when using standalone components, it's much more frequent, because the import needs to be repeated on every component that needs the directive, and of course we tend to only import what's absolutely needed. After migrating two relatively small applications to standalone components, I've introduced such a bug, especially with routerLink, at least twice. I understand why the compiler doesn't complain, but this, IMHO, is a source of hard to detect bugs: I doubt most people have integration tests checking that each and every link in their components works as expected. And even at runtime, the bug goes unnoticed until you click on the link and realize it doesn't work. It would be nice to be able to activate some compiler option that would, for example, check that any non-standard HTML attribute used in a component (such as routerLink) matches with a known directive selector for that component. Or to be able to provide a list of selectors or attributes that must be checked. |
+💯 huge bug source... I'd love to see a strict build option that complains about any "unknown attribute". This way we are sure that imports are not missing. Rather than maintaining a list of all known html attributes (if that is the main concern/difficulty)... at least give us a "allowedAttributes: []" where we can specify which attributes are safe to ignore (do not require an import). |
To me this a pretty big design flaw 🤔 |
I don't know if this is the same - I think might be another use case. We have lots of custom form control components to use inside mat-form-field. The compiler also doesn't detect these as being missed if they are in the template but not imported in the standalone component. Should I raise a new issue for this or is the underlying problem the same? Here app-rich-text-form-control isn't imported but the compiler doesn't pick it up. Fails at runtime
|
+1 for major pain point with standalone components |
I am also feeling sad when migrated but missing the tool support. thanks @kyjus25 for alternatives. |
My suggestion would be to solve this with a new extended diagnosis. The new diagnosis would warns for unknown tags and unknown attributes. Each project can gradually configure the diagnosis with a list of allowed unknown tags and allowed unknown attributes. In addition users can opt-in for this rule to break the build by configuring the diagnostic as an error, to be really strict. Of course this is not an ideal solution, but it should be relatively simple to implement. And it would be better than runtime errors, and so much better than runtime lack of functionality (as seen with |
@PowerKiKi I'm fine with not ideal as long as it provides some peace of mind. Nothing scarier than deploying code that may or may not be silently broken. To me this seems like top priority |
Since when though did it work for non-standalone components? |
Is there any progress on this? I tried using the angular extended diagnosis and hoped the error missingControlFlowDirective would be thrown at compile time by adding this to my
According to the docs this should report missing imports of structural directives as errors
However, this only works partially. It works for structural directives that are applied on html elements or |
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
When standalone component is created with
@Component({ selector: 'button[cv-button]'
it will be not reported during compile timePlease provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-standalone-uzrsmn?file=src%2Fmain.ts
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: