Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(forms): add an example for async validator token #44301

Closed
wants to merge 1 commit into from
Closed

docs(forms): add an example for async validator token #44301

wants to merge 1 commit into from

Conversation

ramthir
Copy link
Contributor

@ramthir ramthir commented Nov 29, 2021

to be consistent with the validator token, have the example code for the async validator token.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

We have an example code for NG_VALIDATORS but not for NG_ASYNC_VALIDATORS.

Issue Number: N/A

What is the new behavior?

An example is added for NG_ASYNC_VALIDATORS token.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@pullapprove pullapprove bot requested a review from dylhunn November 29, 2021 08:58
@ngbot ngbot bot added this to the Backlog milestone Nov 29, 2021
AndrewKushnir
AndrewKushnir reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramthir thanks for improving the docs 👍 The change looks good, I've just left 1 comment.

Could you please also change the commit message to start with docs(forms): (the lint CI job is failing because of unrecognized doc: type)?

packages/forms/src/validators.ts Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Nov 30, 2021
@ramthir
docs(forms): add an example for async validator token
d6afa8f 
to be consistent with the validator token, have the example code for the async validator token.
@ramthir ramthir changed the title doc: add an example for async validator token doc(form): add an example for async validator token Nov 30, 2021
@AndrewKushnir AndrewKushnir changed the title doc(form): add an example for async validator token doc(forms): add an example for async validator token Nov 30, 2021
@AndrewKushnir AndrewKushnir removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 30, 2021
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn November 30, 2021 04:58
@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2021
@AndrewKushnir
Copy link
Contributor

@ramthir thanks for the update, I'm adding this PR to the merge queue. Thanks for improving Angular docs 👍

@AndrewKushnir AndrewKushnir changed the title doc(forms): add an example for async validator token docs(forms): add an example for async validator token Nov 30, 2021
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 30, 2021
@AndrewKushnir
Copy link
Contributor

Merge assistance: the legacy-unit-tests-saucelabs CI job was failing for unrelated reasons. The PR is ready for merge.

@dylhunn
Copy link
Contributor

dylhunn commented Nov 30, 2021

This PR was merged into the repository by commit 24baa5e.

dylhunn pushed a commit that referenced this pull request Nov 30, 2021
@ramthir @dylhunn
docs(forms): add an example for async validator token (#44301)
53bdf11 
to be consistent with the validator token, have the example code for the async validator token.

PR Close #44301
@dylhunn dylhunn closed this in 24baa5e Nov 30, 2021
@ramthir ramthir deleted the async-validators-usage branch November 30, 2021 23:56
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@ramthir @dimakuba
docs(forms): add an example for async validator token (angular#44301)
2937ee4 
to be consistent with the validator token, have the example code for the async validator token.

PR Close angular#44301
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ramthir @AndrewKushnir @dylhunn @jessicajaniuk