Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(router): add type annotation for UrlSegment.parameterMap #44175

Closed
wants to merge 1 commit into from

Conversation

gagern
Copy link
Contributor

@gagern gagern commented Nov 15, 2021

Having the type specified explicitly makes the API reference more readable.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Please double-check my choice.

What is the current behavior?

Issue Number: N/A

Reading https://angular.io/api/router/UrlSegment, the type of parameterMap is unclear. I had to dig through code to work it out.

What is the new behavior?

The type is fully annotated so documentation can reference it clearly.

Does this PR introduce a breaking change?

  • Yes
  • No

Having the type specified explicitly makes the API reference more readable.
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@pullapprove pullapprove bot requested a review from atscott November 15, 2021 14:34
@gagern
Copy link
Contributor Author

gagern commented Nov 16, 2021

ci/circleci: legacy-unit-tests-saucelabs currently fails stating “Disconnected , because no message in 300000 ms”. Doesn't sound related to my change. Is that test flaky? https://app.circleci.com/pipelines/github/angular/angular suggests it has been failing on a number of recent runs. @atscott can you trigger a re-run?

@atscott
Copy link
Contributor

atscott commented Nov 16, 2021

@gagern Yes, this test is known to be flaky at the moment. Marking as merge-ready

@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Nov 16, 2021
@ngbot
Copy link

ngbot bot commented Nov 16, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    pending missing required status "cla/google"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott
Copy link
Contributor

atscott commented Nov 16, 2021

merge-assistance: Unrelated test failure

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit aac579d.

AndrewKushnir pushed a commit that referenced this pull request Nov 16, 2021
…4175)

Having the type specified explicitly makes the API reference more readable.
PR Close #44175
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
…gular#44175)

Having the type specified explicitly makes the API reference more readable.
PR Close angular#44175
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants