-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router): add type annotation for UrlSegment.parameterMap #44175
Conversation
Having the type specified explicitly makes the API reference more readable.
ci/circleci: legacy-unit-tests-saucelabs currently fails stating “Disconnected , because no message in 300000 ms”. Doesn't sound related to my change. Is that test flaky? https://app.circleci.com/pipelines/github/angular/angular suggests it has been failing on a number of recent runs. @atscott can you trigger a re-run? |
@gagern Yes, this test is known to be flaky at the moment. Marking as merge-ready |
merge-assistance: Unrelated test failure |
This PR was merged into the repository by commit aac579d. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…gular#44175) Having the type specified explicitly makes the API reference more readable. PR Close angular#44175
Having the type specified explicitly makes the API reference more readable.
PR Checklist
Please check if your PR fulfills the following requirements:
Tests for the changes have been added(for bug fixes / features)Docs have been added / updated(for bug fixes / features)PR Type
What kind of change does this PR introduce?
Please double-check my choice.
What is the current behavior?
Issue Number: N/A
Reading https://angular.io/api/router/UrlSegment, the type of
parameterMap
is unclear. I had to dig through code to work it out.What is the new behavior?
The type is fully annotated so documentation can reference it clearly.
Does this PR introduce a breaking change?