Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: type spy objects in test example. #44170

Closed
wants to merge 1 commit into from
Closed

test: type spy objects in test example. #44170

wants to merge 1 commit into from

Conversation

ramthir
Copy link
Contributor

@ramthir ramthir commented Nov 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Spy objects in the test example are not typed.

Issue Number: N/A

What is the new behavior?

Spy objects in the test example are typed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: no label Nov 14, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 14, 2021
@ramthir ramthir changed the title refactor(aio): type spy objects in tests. refactor: type spy objects in test example. Nov 14, 2021
Example for test doesn't use typing for Jasmine Spy objects. Updated 
them with `SpyObj<T>` typing as in the Angular Documentation.

See https://angular.io/guide/testing-services
@ramthir ramthir changed the title refactor: type spy objects in test example. test: type spy objects in test example. Nov 14, 2021
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving tests and docs 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release labels Nov 16, 2021
@ngbot ngbot bot modified the milestone: Backlog Nov 16, 2021
@ngbot
Copy link

ngbot bot commented Nov 16, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    pending missing required status "cla/google"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 16, 2021
@AndrewKushnir
Copy link
Contributor

Note to the Caretaker: the legacy-unit-tests-saucelabs CI job failures are unrelated, so we can proceed with the merge.

@ramthir ramthir closed this Nov 16, 2021
@ramthir ramthir reopened this Nov 16, 2021
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 6d2276e.

AndrewKushnir pushed a commit that referenced this pull request Nov 16, 2021
Example for test doesn't use typing for Jasmine Spy objects. Updated 
them with `SpyObj<T>` typing as in the Angular Documentation.

See https://angular.io/guide/testing-services

PR Close #44170
@ramthir ramthir deleted the type-test-spy-objects branch November 17, 2021 01:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
Example for test doesn't use typing for Jasmine Spy objects. Updated 
them with `SpyObj<T>` typing as in the Angular Documentation.

See https://angular.io/guide/testing-services

PR Close angular#44170
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants