-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: type spy objects in test example. #44170
Conversation
Example for test doesn't use typing for Jasmine Spy objects. Updated them with `SpyObj<T>` typing as in the Angular Documentation. See https://angular.io/guide/testing-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving tests and docs 👍
Note to the Caretaker: the |
This PR was merged into the repository by commit 6d2276e. |
Example for test doesn't use typing for Jasmine Spy objects. Updated them with `SpyObj<T>` typing as in the Angular Documentation. See https://angular.io/guide/testing-services PR Close #44170
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Example for test doesn't use typing for Jasmine Spy objects. Updated them with `SpyObj<T>` typing as in the Angular Documentation. See https://angular.io/guide/testing-services PR Close angular#44170
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Spy objects in the test example are not typed.
Issue Number: N/A
What is the new behavior?
Spy objects in the test example are typed.
Does this PR introduce a breaking change?
Other information