Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(animations): improve wording for animation example #44168

Closed
wants to merge 1 commit into from

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Nov 14, 2021

improve the wording of the text explaining an animation
code snippet as that can be misinterpreted

resolves #43952

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

The code snippet is explained in an unclear (and in my opinion wrong) way:

Screenshot at 2021-11-14 10-42-51

What is the new behavior?

The text is simplified and clearer:

Screenshot at 2021-11-14 10-48-53

Note that animations are applied to html elements, not components, so that's why I believe "component" is wrong there and I substituted it with "element"

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla google-cla bot added the cla: yes label Nov 14, 2021
@pullapprove pullapprove bot requested a review from crisbeto November 14, 2021 10:51
improve the wording of the text explaining an animation
code snippet as that can be misinterpreted

resolves angular#43952
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview area: animations comp: docs target: patch This PR is targeted for the next patch release labels Nov 15, 2021
@mary-poppins
Copy link

You can preview 29e9292 at https://pr44168-29e9292.ngbuilds.io/.
You can preview 1e4dc66 at https://pr44168-1e4dc66.ngbuilds.io/.

@ngbot ngbot bot modified the milestone: Backlog Nov 15, 2021
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2021
@ngbot
Copy link

ngbot bot commented Nov 16, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    pending status "google3" is pending
    pending status "pullapprove" is pending
    pending missing required status "cla/google"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor

Note to the Caretaker: this change is safe to land (CI job failure is unrelated and Pete's approval should be enough for this docs-only change).

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 00ae55c.

AndrewKushnir pushed a commit that referenced this pull request Nov 16, 2021
improve the wording of the text explaining an animation
code snippet as that can be misinterpreted

resolves #43952

PR Close #44168
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
improve the wording of the text explaining an animation
code snippet as that can be misinterpreted

resolves angular#43952

PR Close angular#44168
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: animations cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for angular animation asterisk token for height and width might be wrong
4 participants