Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Windows support for tsec_test. #44130

Closed
wants to merge 1 commit into from
Closed

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Nov 10, 2021

cherry-pick to patch branch of #43924

Contents of generated tsconfig for tsec_test now depend on whether
Bazel uses symlinked runfiles for nodejs_test. The current
implementation assumes that symlinked runfiles are not available
on Windows.
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@atscott atscott added target: patch This PR is targeted for the next patch release and removed cla: yes labels Nov 10, 2021
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@atscott atscott mentioned this pull request Nov 10, 2021
14 tasks
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

note: cherry-pick

Reviewed-for: global-approvers

@IgorMinar IgorMinar removed the request for review from jelbourn November 10, 2021 17:47
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Nov 10, 2021
@atscott
Copy link
Contributor Author

atscott commented Nov 10, 2021

This PR was merged into the repository by commit bfb2882.

@atscott atscott closed this Nov 10, 2021
atscott pushed a commit that referenced this pull request Nov 10, 2021
Contents of generated tsconfig for tsec_test now depend on whether
Bazel uses symlinked runfiles for nodejs_test. The current
implementation assumes that symlinked runfiles are not available
on Windows.

PR Close #44130
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants