Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(compiler): remove IE11 match in JIT compiler tests #44122

Closed
wants to merge 1 commit into from
Closed

test(compiler): remove IE11 match in JIT compiler tests #44122

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Since we no longer support (nor test on) IE11 we can remove these matches
for anonymous functions.

@petebacondarwin
test(compiler): remove IE11 match in JIT compiler tests
262c4b7 
Since we no longer support (nor test on) IE11 we can remove these matches
for `anonymous` functions.
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Nov 9, 2021
@ngbot ngbot bot modified the milestone: Backlog Nov 9, 2021
@google-cla google-cla bot added the cla: yes label Nov 9, 2021
JoostK
JoostK approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; merging this with a red legacy-unit-tests-suacelabs might be risky.

jessicajaniuk
jessicajaniuk approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

@petebacondarwin petebacondarwin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 10, 2021
@petebacondarwin
Copy link
Member Author

CI is green!!

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Nov 10, 2021
@atscott
Copy link
Contributor

atscott commented Nov 10, 2021

This PR was merged into the repository by commit 18cc7c8.

@atscott atscott closed this in 18cc7c8 Nov 10, 2021
atscott pushed a commit that referenced this pull request Nov 10, 2021
@petebacondarwin @atscott
test(compiler): remove IE11 match in JIT compiler tests (#44122)
18cc5f5 
Since we no longer support (nor test on) IE11 we can remove these matches
for `anonymous` functions.

PR Close #44122
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
@petebacondarwin @dimakuba
test(compiler): remove IE11 match in JIT compiler tests (angular#44122)
6a3725c 
Since we no longer support (nor test on) IE11 we can remove these matches
for `anonymous` functions.

PR Close angular#44122
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petebacondarwin @atscott @JoostK @jessicajaniuk