refactor(core): remove outdated comment

[dario-piotrowicz]

remove the comment suggesting to use an enum for ViewEncapsulation as
the change seems to have already been applied in PR #25255

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

A code comment seems to be present but no longer valid.

Prior to PR #25255 the check for the encapsulation was done using a 2 and the comment suggested to substitute that with an enum, that seems to have been already done in the aforementioned PR

As you can see here:

What is the new behavior?

The comment has been removed

Does this PR introduce a breaking change?

• Yes
• No

Other information

• The comment also suggest that None should be 0 and not 2, is such a change still on the table?
  seems pretty risky and not too beneficial to me at this point, but since the enum is used maybe it could be fine? 🤷‍♂️
  anyways if that's the case I would suggest to put a comment for that in the enum itself
  (
  by the way, there's also a 1 not being used anymore there

  angular/packages/core/src/metadata/view.ts

  Line 32 in a92a89b

  // Historically the 1 value was for `Native` encapsulation which has been removed as of v11.

  )

[mary-poppins]

You can preview 3b7b1b3 at https://pr44099-3b7b1b3.ngbuilds.io/.

[AndrewKushnir]

@dario-piotrowicz thanks for the cleanup 👍

[mary-poppins]

You can preview 67fb31a at https://pr44099-67fb31a.ngbuilds.io/.

[dario-piotrowicz]

@dario-piotrowicz thanks for moving the comment! Everything looks good, we just need to make sure that the updated files are formatted correctly (see the "lint" CI job output).

Sorry @AndrewKushnir I misread your comment and thought that we were waiting for some check, I didn't get that the check was failing 😅, I've fixed it, seems like the comment was too long so I broke it into two (0334d21)
(that's actually the automatic linter's fix)

I hope it's fine 🙂

[mary-poppins]

You can preview 0334d21 at https://pr44099-0334d21.ngbuilds.io/.

[AndrewKushnir]

Note to the Caretaker: the legacy-unit-tests-saucelabs job is failing for unrelated reasons (timeouts). This change updates some comments, so it's safe to land.

[atscott]

This PR was merged into the repository by commit 0bd01ca.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}