Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:update review tag to topic #44008

Closed
wants to merge 1 commit into from
Closed

Conversation

ileil
Copy link
Contributor

@ileil ileil commented Nov 1, 2021

Update the review tag to test out the angular workflow

@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@pullapprove pullapprove bot requested a review from jelbourn November 1, 2021 18:19
@aikithoughts aikithoughts requested review from josephperrott and aikithoughts and removed request for jelbourn November 1, 2021 18:20
@pullapprove pullapprove bot requested a review from jelbourn November 1, 2021 18:20
@aikithoughts aikithoughts added the target: patch This PR is targeted for the next patch release label Nov 1, 2021
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-docs-approvers

@ngbot
Copy link

ngbot bot commented Nov 6, 2021

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@petebacondarwin
Copy link
Member

I took the liberty of rebasing this and amending the commit to pass the lint check - (the docs: needs a space after it).

@ngbot ngbot bot added this to the Backlog milestone Nov 9, 2021
@atscott
Copy link
Contributor

atscott commented Nov 10, 2021

This PR was merged into the repository by commit 790dfe5.

@atscott atscott closed this in 790dfe5 Nov 10, 2021
atscott pushed a commit that referenced this pull request Nov 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants