Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add armen vardanyan to GDE resources #43919

Conversation

Armenvardanyan95
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla
Copy link

google-cla bot commented Oct 21, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 21, 2021
@pullapprove pullapprove bot requested a review from twerske October 21, 2021 09:30
@petebacondarwin
Copy link
Member

@Armenvardanyan95 - I approved the content from a technical point of view (i.e. I checked the github and twitter accounts).

Please can you fix the image size:

Error: The following pictures exceed maximum size limit of 30kb:
  - /home/circleci/ng/aio/content/images/bios/armen-vardanyan.jpg

@ngbot ngbot bot added this to the Backlog milestone Oct 21, 2021
@petebacondarwin petebacondarwin added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Oct 21, 2021
@google-cla
Copy link

google-cla bot commented Oct 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Armenvardanyan95
Copy link
Contributor Author

@petebacondarwin thanks for the notice, I reduced the image size

@petebacondarwin
Copy link
Member

Thanks @Armenvardanyan95 - please can you squash the three commits into one - or if you want to keep three, make the second two commits fixup commits.

Also it appears that there is still a problem with your CLA signature.

Copy link
Contributor

@twerske twerske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Pete's comments are fixed

@Armenvardanyan95
Copy link
Contributor Author

@petebacondarwin I will squash the commits, but want to know how to fix the cla problem. Apparently I committed using my work mail instead of my personal mail, do I rebase my commits and change the email address on the commits?

@petebacondarwin
Copy link
Member

@Armenvardanyan95 - I think the best way is to squash the commits into one, then manually update the commit author on this commit to the same email address that you are logged into Github. So something like:

git fetch upstream master
git rebase -i upstream/master
# mark the 2nd and 3rd commits as fixups
git commit --amend --author="John Doe <john@doe.org>"
git push --force-with-lease

@Armenvardanyan95 Armenvardanyan95 force-pushed the docs/contributors-gde-armenvardanyan branch from 75b8706 to 60fea81 Compare November 1, 2021 07:19
@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 1, 2021
@Armenvardanyan95
Copy link
Contributor Author

@petebacondarwin thanks for guidance, done, now there is only one commit with the correct email ✔️

@petebacondarwin
Copy link
Member

Thanks for sorting out the CLA problem @Armenvardanyan95.
Can you do one final rebase on the upstream master to trigger the CI to run?
Thanks!

@petebacondarwin petebacondarwin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 3, 2021
@Armenvardanyan95
Copy link
Contributor Author

@petebacondarwin sorry I somehow missed your comment
I didn't quite get that, how I should do it?

@petebacondarwin
Copy link
Member

Hi @Armenvardanyan95 - no problem. This is what I would recommend...

Let's assume that you have a "git remote" set up that points the main angular/angular repo called upstream.
Then you could do:

git fetch upstream master
git checkout docs/contributors-gde-armenvardanyan
git rebase upstream/master
git push --force-with-lease

Or if you wanted to also update your local master branch as well (and if it was already tied to the upstream remote) you could simply do:

git checkout master
git pull
git checkout docs/contributors-gde-armenvardanyan
git rebase master
git push --force-with-lease

@AndrewKushnir AndrewKushnir force-pushed the docs/contributors-gde-armenvardanyan branch from 60fea81 to c3e15a2 Compare November 16, 2021 20:26
@AndrewKushnir
Copy link
Contributor

FYI, I've pushed a rebase and if the CI is "green", we should be able to proceed with the merge.

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2021
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 130f06e.

@Armenvardanyan95
Copy link
Contributor Author

@AndrewKushnir thank you!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2021
dimakuba pushed a commit to dimakuba/angular that referenced this pull request Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants