-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add armen vardanyan to GDE resources #43919
docs: add armen vardanyan to GDE resources #43919
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@Armenvardanyan95 - I approved the content from a technical point of view (i.e. I checked the github and twitter accounts). Please can you fix the image size:
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@petebacondarwin thanks for the notice, I reduced the image size |
Thanks @Armenvardanyan95 - please can you squash the three commits into one - or if you want to keep three, make the second two commits Also it appears that there is still a problem with your CLA signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once Pete's comments are fixed
@petebacondarwin I will squash the commits, but want to know how to fix the cla problem. Apparently I committed using my work mail instead of my personal mail, do I rebase my commits and change the email address on the commits? |
@Armenvardanyan95 - I think the best way is to squash the commits into one, then manually update the commit author on this commit to the same email address that you are logged into Github. So something like: git fetch upstream master
git rebase -i upstream/master
# mark the 2nd and 3rd commits as fixups
git commit --amend --author="John Doe <john@doe.org>"
git push --force-with-lease |
75b8706
to
60fea81
Compare
@petebacondarwin thanks for guidance, done, now there is only one commit with the correct email ✔️ |
Thanks for sorting out the CLA problem @Armenvardanyan95. |
@petebacondarwin sorry I somehow missed your comment |
Hi @Armenvardanyan95 - no problem. This is what I would recommend... Let's assume that you have a "git remote" set up that points the main angular/angular repo called
Or if you wanted to also update your local
|
60fea81
to
c3e15a2
Compare
FYI, I've pushed a rebase and if the CI is "green", we should be able to proceed with the merge. |
This PR was merged into the repository by commit 130f06e. |
@AndrewKushnir thank you! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?