Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(docs-infra): AIO cannot build with Node.js v12 #42086

Closed
lacolaco opened this issue May 14, 2021 · 8 comments
Closed

bug(docs-infra): AIO cannot build with Node.js v12 #42086

lacolaco opened this issue May 14, 2021 · 8 comments
Labels
area: build & ci Related the build and CI infrastructure of the project
Milestone
needsTriage

Comments

@lacolaco
Copy link
Contributor

Docs or angular.io Bug Report

Description

angular/aio/tools/transforms/angular-api-package/processors/processNgModuleDocs.js

Line 100 in 2e7eb27

if (injectableDoc.symbol?.exports.has('ɵprov')) {

Because optional chaining is supported since Node.js v14, the current AIO build process fails on Node.js v12.
But AIO allows both v12 and v14. This is inconsistent.

angular/aio/package.json

Line 82 in 2e7eb27

"node": "^12.20.0 || ^14.0.0",

Option 1. fix code for Node.js v12 compatibility
Option 2. allow v14 only

I can submit a patch for whichever, but I'd like to know which AIO team prefers.
@lacolaco
Copy link
Contributor Author

cc/ @gkalpak @petebacondarwin

@petebacondarwin
Copy link
Member

We should not allow node v12 in aio. Thanks @lacolaco

@lacolaco lacolaco mentioned this issue May 14, 2021
Closed
14 tasks
lacolaco added a commit to lacolaco/angular that referenced this issue May 14, 2021
@lacolaco
build(docs-infra): allow only Node.js v14 and above
fb8c041 
The AIO doc-gen uses JavaScript syntax that requires node.js 14.0.0 or above.

Closes angular#42086
@zarend zarend added the area: build & ci Related the build and CI infrastructure of the project label May 14, 2021
@ngbot ngbot bot added this to the needsTriage milestone May 14, 2021
zarend pushed a commit that referenced this issue May 26, 2021
@lacolaco @zarend
build(docs-infra): allow only Node.js v14 and above (#42093)
6c136f3 
The AIO doc-gen uses JavaScript syntax that requires node.js 14.0.0 or above.

Closes #42086

PR Close #42093
@zarend zarend closed this as completed in 33e1a18 May 26, 2021
@vladimiry
Copy link

vladimiry commented May 26, 2021 •
edited

Should not the range to be >=14.0.0 vs currently used ^14.0.0? See #42076 and 1c3fe69...9f09c3b.

@petebacondarwin
Copy link
Member

@vladimiry - yes you are correct. Do you want to submit a further PR?

@vladimiry
Copy link

Do you want to submit a further PR?

Nope, going to sleep soon.

@petebacondarwin
Copy link
Member

Do you want to submit a further PR?

Nope, going to sleep soon.

A very sensible thing to do. I should do the same 👍

@zarend
Copy link
Contributor

zarend commented May 26, 2021 •
edited

#42367 is merged, and it sets the range in aio to >=14.0.0 ✔️

umairhm pushed a commit to umairhm/angular that referenced this issue May 28, 2021
@lacolaco @umairhm
build(docs-infra): allow only Node.js v14 and above (angular#42093)
2662373 
The AIO doc-gen uses JavaScript syntax that requires node.js 14.0.0 or above.

Closes angular#42086

PR Close angular#42093
iRealNirmal pushed a commit to iRealNirmal/angular that referenced this issue Jun 4, 2021
@lacolaco @iRealNirmal
build(docs-infra): allow only Node.js v14 and above (angular#42093)
0da8d70 
The AIO doc-gen uses JavaScript syntax that requires node.js 14.0.0 or above.

Closes angular#42086

PR Close angular#42093
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(docs-infra): allow only Node.js v14 lacolaco/angular
4 participants
@petebacondarwin @lacolaco @vladimiry @zarend