Update node engines field in package.jsons to be more correct
#41822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the node version requirements to only include the LTS versions supported, rather than accidently including the active versions.
…ude LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…TS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…clude LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…e LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…e LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…TS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…y include LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…e LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…s to only include LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…y include LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
… include LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…include LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
… LTS versions Update the supported range of node versions for Angular to only include supported LTS versions.
…S versions Update the supported range of node versions for Angular to only include supported LTS versions.
josephperrott
added
action: merge
|
@jelbourn Can I have you provide a review on this rather than having PullApprove request 9 reviews. |
alan-agius4
approved these changes
Apr 26, 2021
kyliau
pushed a commit
to kyliau/angular
that referenced
this pull request
Apr 27, 2021
…S versions (angular#41822) Update the supported range of node versions for Angular to only include supported LTS versions. PR Close angular#41822
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the node version requirements to only include the LTS versions supported, rather than accidentally including the active versions.
Individual commits are used for properly scoping the changes, though the same change is being made in different places throughout the repository.