fix(compiler): strip scoped selectors from @font-face rules
#41815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
action: review
petebacondarwin
force-pushed
the
ng-deep-issue-41751
branch
from
805aaff
to
fe9cecd
Compare
jessicajaniuk
added
the
area: compiler
petebacondarwin
added
the
action: presubmit
AndrewKushnir
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
@petebacondarwin thanks for the fix 👍
I really like the PR description and I'm wondering if we can move some of that content (or actually all of it) to the _stripScopingSelectors function docs as an additional context for future maintenance?
AndrewKushnir
removed
the
action: review
|
Added the comment. Marking for merge, pending the outcome of the presubmit. |
`@font-face` rules cannot contain nested selectors. Nor can they be nested under a selector. Normally this would be a syntax error by the author of the styles. But in some rare cases, such as importing styles from a library, and applying `:host ::ng-deep` to the imported styles, we can end up with broken css if the imported styles happen to contain `@font-face` rules. This commit works around this problem by sanitizing such cases (erasing any scoping selectors) during emulated ShadowDOM encapsulation style processing. Fixes angular#41751
petebacondarwin
force-pushed
the
ng-deep-issue-41751
branch
from
fe9cecd
to
6a01493
Compare
petebacondarwin
added
the
action: merge
jessicajaniuk
removed
the
action: presubmit
jessicajaniuk
pushed a commit
that referenced
this pull request
Apr 27, 2021
`@font-face` rules cannot contain nested selectors. Nor can they be nested under a selector. Normally this would be a syntax error by the author of the styles. But in some rare cases, such as importing styles from a library, and applying `:host ::ng-deep` to the imported styles, we can end up with broken css if the imported styles happen to contain `@font-face` rules. This commit works around this problem by sanitizing such cases (erasing any scoping selectors) during emulated ShadowDOM encapsulation style processing. Fixes #41751 PR Close #41815
jessicajaniuk
pushed a commit
that referenced
this pull request
Apr 27, 2021
`@font-face` rules cannot contain nested selectors. Nor can they be nested under a selector. Normally this would be a syntax error by the author of the styles. But in some rare cases, such as importing styles from a library, and applying `:host ::ng-deep` to the imported styles, we can end up with broken css if the imported styles happen to contain `@font-face` rules. This commit works around this problem by sanitizing such cases (erasing any scoping selectors) during emulated ShadowDOM encapsulation style processing. Fixes #41751 PR Close #41815
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@font-facerules cannot contain nested selectors. Nor can they benested under a selector. Normally this would be a syntax error by the
author of the styles. But in some rare cases, such as importing styles
from a library, and applying
:host ::ng-deepto the imported styles,we can end up with broken css if the imported styles happen to contain
@font-facerules.This commit works around this problem by sanitizing such cases (erasing
any scoping selectors) during emulated ShadowDOM encapsulation style
processing.
Fixes #41751