Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linker): minified umd fixes #41747

Closed
wants to merge 3 commits into from
Closed

fix(linker): minified umd fixes #41747

wants to merge 3 commits into from

Conversation

petebacondarwin
Copy link
Member

Closes #41655

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate compiler: linker labels Apr 21, 2021
@ngbot ngbot bot modified the milestone: Backlog Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@pullapprove pullapprove bot requested a review from alxhub April 21, 2021 13:43
@petebacondarwin petebacondarwin requested review from JoostK and removed request for alxhub April 21, 2021 13:44
JoostK
JoostK reviewed Apr 21, 2021
View reviewed changes
packages/compiler-cli/linker/src/ast/typescript/typescript_ast_host.ts Outdated Show resolved Hide resolved
packages/compiler-cli/linker/babel/src/ast/babel_ast_host.ts Outdated Show resolved Hide resolved
packages/compiler-cli/linker/babel/test/ast/babel_ast_host_spec.ts Show resolved Hide resolved
packages/compiler-cli/linker/babel/src/es2015_linker_plugin.ts
@@ -139,6 +139,8 @@ function getCalleeName(call: NodePath<t.CallExpression>): string|null {
return callee.name;
} else if (t.isMemberExpression(callee) && t.isIdentifier(callee.property)) {
return callee.property.name;
} else if (t.isMemberExpression(callee) && t.isStringLiteral(callee.property)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also support this case in AstHost.getSymbolName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case was not reported as problematic in the original issue, so I was being conservative in adding support. I would rather wait to see if we get any further issues. It is an easy fix to add in the future if it comes up.

@petebacondarwin
fix(compiler-cli): allow linker to process minified booleans
ea85ff5 
Some partial libraries have been minified, which results in boolean literals
being converted to `!0` and `!1`. This commit ensures that the linker can
process these values.

Fixes angular#41655
@petebacondarwin
fix(compiler-cli): match string indexed partial declarations
a7c015b 
Some partial libraries have been minified, which results in the declaration
calls being being converted from property accesses to indexed accesses.
This commit ensures that the linker can process these calls.

Fixes angular#41655
@petebacondarwin petebacondarwin force-pushed the linker-minified-umd-fix-issue-41655 branch 2 times, most recently from 264b31d to f20d79f Compare April 22, 2021 08:31
@petebacondarwin petebacondarwin force-pushed the linker-minified-umd-fix-issue-41655 branch from f20d79f to 3edd153 Compare April 22, 2021 08:51
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 22, 2021
jessicajaniuk pushed a commit that referenced this pull request Apr 22, 2021
@petebacondarwin @jessicajaniuk
fix(compiler-cli): allow linker to process minified booleans (#41747)
1fb6724 
Some partial libraries have been minified, which results in boolean literals
being converted to `!0` and `!1`. This commit ensures that the linker can
process these values.

Fixes #41655

PR Close #41747
jessicajaniuk pushed a commit that referenced this pull request Apr 22, 2021
@petebacondarwin @jessicajaniuk
fix(compiler-cli): match string indexed partial declarations (#41747)
f885750 
Some partial libraries have been minified, which results in the declaration
calls being being converted from property accesses to indexed accesses.
This commit ensures that the linker can process these calls.

Fixes #41655

PR Close #41747
jessicajaniuk pushed a commit that referenced this pull request Apr 22, 2021
@petebacondarwin @jessicajaniuk
fix(compiler-cli): match string indexed partial declarations (#41747)
c3a512a 
Some partial libraries have been minified, which results in the declaration
calls being being converted from property accesses to indexed accesses.
This commit ensures that the linker can process these calls.

Fixes #41655

PR Close #41747
@petebacondarwin petebacondarwin deleted the linker-minified-umd-fix-issue-41655 branch April 27, 2021 18:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes compiler: linker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Angular linker cannot compile umd.min.js
2 participants
@petebacondarwin @JoostK